Skip to content

Commit

Permalink
fix(dpd): also use city for pick up locations (#182)
Browse files Browse the repository at this point in the history
Co-authored-by: Edie Lemoine <[email protected]>
  • Loading branch information
RichardPerdaan and EdieLemoine authored Jun 21, 2023
1 parent 42f2e0f commit e5610ef
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/data/carriers/dpdCarrierConfiguration.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import {
SWEDEN,
UNITED_KINGDOM,
} from '@myparcel/js-sdk/dist/constant/countries-iso2';
import { POSTAL_CODE, STREET } from '../keys/addressKeys';
import { CITY, POSTAL_CODE, STREET } from '../keys/addressKeys';
import { AbstractCarrierConfiguration } from '@/data/carriers/abstractCarrierConfiguration';
import { DPD } from '../keys/carrierKeys';
import { SENDMYPARCEL } from '@/data/keys/platformKeys';
Expand All @@ -38,7 +38,7 @@ export class DpdCarrierConfiguration extends AbstractCarrierConfiguration {
}

getDefaultRequestParameters() {
return [POSTAL_CODE, STREET];
return [POSTAL_CODE, STREET, CITY];
}

getCountriesForDelivery() {
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/delivery-options/getRequestParameters.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ describe('Request parameters', () => {
${POSTNL} | ${PLATFORMS.MYPARCEL} | ${['postal_code', 'city', 'street']}
${POSTNL} | ${PLATFORMS.SENDMYPARCEL} | ${['postal_code', 'city', 'street']}
${BPOST} | ${PLATFORMS.SENDMYPARCEL} | ${['postal_code', 'city']}
${DPD} | ${PLATFORMS.SENDMYPARCEL} | ${['postal_code', 'street']}
${DPD} | ${PLATFORMS.SENDMYPARCEL} | ${['postal_code', 'city', 'street']}
${DHL} | ${PLATFORMS.MYPARCEL} | ${['postal_code', 'city']}
${DHL_FOR_YOU} | ${PLATFORMS.MYPARCEL} | ${['postal_code', 'city']}
${DHL_EUROPLUS} | ${PLATFORMS.MYPARCEL} | ${['postal_code', 'city', 'street']}
Expand Down

0 comments on commit e5610ef

Please sign in to comment.