Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prestashop): fix some bugs in image #17

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

EdieLemoine
Copy link
Contributor

@EdieLemoine EdieLemoine commented Sep 19, 2024

  • fix permissions before cache steps
  • fix memory limit error when clearing and warming up cache
  • display full url on start
  • clean up env vars
  • install cli dependencies on start
  • improve installation and theme building for all ps versions

@myparcel-bot myparcel-bot bot force-pushed the fix/prestashop-variables branch from ea1da6b to 8b4b5d3 Compare September 19, 2024 10:33
@myparcelnl myparcelnl deleted a comment from gitguardian bot Sep 19, 2024
Copy link

gitguardian bot commented Sep 19, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@myparcel-bot myparcel-bot bot force-pushed the fix/prestashop-variables branch 4 times, most recently from 7fd2ccd to 5f6b90f Compare September 19, 2024 13:46
@EdieLemoine EdieLemoine force-pushed the fix/prestashop-variables branch from ab10faf to 5f6b90f Compare September 19, 2024 14:38
@myparcel-bot myparcel-bot bot force-pushed the fix/prestashop-variables branch 2 times, most recently from 1de21e5 to 5742b24 Compare September 19, 2024 14:43
@EdieLemoine EdieLemoine changed the title fix(prestashop): display full url on start and untangle env vars fix(prestashop): improve image Sep 19, 2024
@EdieLemoine EdieLemoine changed the title fix(prestashop): improve image fix(prestashop): fix some bugs in image Sep 19, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix/prestashop-variables branch 2 times, most recently from 8a4cbf0 to 7ca5b81 Compare September 20, 2024 13:36
@myparcel-bot myparcel-bot bot force-pushed the fix/prestashop-variables branch from 7ca5b81 to 1914470 Compare September 20, 2024 13:50
@EdieLemoine EdieLemoine merged commit 5876d3b into main Oct 4, 2024
3 checks passed
@EdieLemoine EdieLemoine deleted the fix/prestashop-variables branch October 4, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants