Invalid scope website when upgrading to 4.14.0

[janssensjelle]

Plugin version

4.14.0

Magento version

2.4.6-p4

PHP version

8.2

What went wrong?

Migration script causes invalid scopes

Reproduction steps

1. Upgrade to 4.14.0 from 4.13.0
2. Start setup:upgrade

Relevant log output

Module 'MyParcelNL_Magento':
Upgrading data..
Migrating postnl for scope default (2)
Migrating dhlforyou for scope default (2)
Migrating dhleuroplus for scope default (2)
Migrating dhlparcelconnect for scope default (2)
Migrating ups for scope default (2)
Migrating dpd for scope default (2)
Migrating postnl for scope stores (2)
Migrating dhlforyou for scope stores (2)
Migrating dhleuroplus for scope stores (2)
Migrating dhlparcelconnect for scope stores (2)
Migrating ups for scope stores (2)
Migrating dpd for scope stores (2)
Migrating postnl for scope website (0)
Enabling caches:
Current status:
layout: 1
block_html: 1
full_page: 1
Invalid scope website

Additional context

It creates invalid configuration like in the screenshot

Also happens when clearing config table from all myparcel configuration.

[joerivanveen]

Good morning @janssensjelle Can you share the contents of the config table regarding all paths starting with 'myparcel' so I can investigate further? You may e-mail the data or screenshot to our support email address, or paste it in this thread.

[janssensjelle]

@joerivanveen , sure, here you go. I have also cleared the entire config data table with anything related to %MyParcel% and the problem still persists.

Before

After clearing everything and running setup:upgrade

[joerivanveen]

Thank you for reporting the issue, I started working on this.
On a separate note, your entries are not at all what I was expecting, are you upgrading from a very old version, or a Belgian version? Is the screenshot from after you deleted myparcel% related entries?

[joerivanveen]

Can you confirm or deny whether the scope website (without ‘s’) exists in your conifg table, and wheter there is a row with scope default and scope_id 2? If so, these are indeed illegal, and then the migration should maybe discard them rather than throw an error. The question is because I am having trouble reproducing your error at the moment.

[janssensjelle]

I had the previous version, v4.13.0 working before.

There indeed is a scope website without 's' from a very old module. Setup:upgrade was working fine before with this in the config table.

After deleting this data the setup:upgrade works again

[joerivanveen]

Hi, thank you for working with me on this so quickly. It is correct that only since 4.14.0 the scopes are used in a migration within the myparcel plugin. I think it might be better if the migration just ignores invalid scopes instead of throwing an error, will make a pr to that effect.

[janssensjelle]

To be honest, I think this migration script should not touch/load any other config entries other than the ones it owns.

[MyParcelBot]

🎉 This issue has been resolved in version 4.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀