Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update insurance settings #856

Merged
merged 18 commits into from
Aug 1, 2024
Merged

feat: update insurance settings #856

merged 18 commits into from
Aug 1, 2024

Conversation

FlorianSDV
Copy link
Contributor

INT-478

@FlorianSDV FlorianSDV requested a review from a team as a code owner July 17, 2024 13:45
EdieLemoine
EdieLemoine suggested changes Jul 18, 2024
View reviewed changes
Model/Source/AbstractInsurancePossibilities.php Outdated Show resolved Hide resolved
Model/Source/AbstractInsurancePossibilities.php Outdated Show resolved Hide resolved
Model/Source/AbstractInsurancePossibilities.php Outdated Show resolved Hide resolved
Model/Source/AbstractInsurancePossibilities.php Outdated Show resolved Hide resolved
Model/Source/AbstractInsurancePossibilities.php Outdated Show resolved Hide resolved
Model/Source/DefaultOptions.php Outdated Show resolved Hide resolved
Model/Source/DefaultOptions.php Outdated Show resolved Hide resolved
EdieLemoine
EdieLemoine suggested changes Jul 18, 2024
View reviewed changes
Model/Source/CarrierInsurancePossibilities.php Outdated Show resolved Hide resolved
Model/Source/CarrierInsurancePossibilities.php Show resolved Hide resolved
Model/Source/CarrierInsurancePossibilities.php Show resolved Hide resolved
Model/Source/CarrierInsurancePossibilities.php Outdated Show resolved Hide resolved
Model/Source/DefaultOptions.php Outdated Show resolved Hide resolved
Model/Source/DefaultOptions.php Outdated Show resolved Hide resolved
Model/Source/DefaultOptions.php Outdated Show resolved Hide resolved
EdieLemoine
EdieLemoine previously approved these changes Jul 18, 2024
View reviewed changes
Model/Source/DefaultOptions.php Outdated Show resolved Hide resolved
Model/Source/DefaultOptions.php Outdated Show resolved Hide resolved
@FlorianSDV FlorianSDV changed the base branch from main to develop August 1, 2024 08:00
@FlorianSDV FlorianSDV dismissed stale reviews from GravendeelJochem and EdieLemoine August 1, 2024 08:00

The base branch was changed.

@FlorianSDV FlorianSDV merged commit 129bd68 into develop Aug 1, 2024
2 checks passed
@FlorianSDV FlorianSDV deleted the update-carrier-insurance-settings branch August 1, 2024 08:31
MyParcelBot pushed a commit that referenced this pull request Aug 6, 2024
@semantic-release-bot
chore(release): 4.16.0 [skip ci]
5652c3f 
## [4.16.0](v4.15.2...v4.16.0) (2024-08-06)

### ✨ New Features

* small package belgium ([#859](#859)) ([84aaae1](84aaae1))
* update insurance settings ([#856](#856)) ([129bd68](129bd68))
@MyParcelBot
Copy link

🎉 This PR is included in version 4.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@barryvdh
Copy link
Contributor

barryvdh commented Aug 7, 2024 

Class "MyParcelNL\Sdk\src\Services\CountryCodes" not found#0 /data/web/magento2_staging/releases/131/setup/src/Magento/Setup/Model/Installer.php(1059): MyParcelNL\Magento\Setup\UpgradeData->upgrade()

The CountryCodes Service does not seem to exist in 7.14.x of the SDK? https://github.com/myparcelnl/sdk/blob/v7.14.1/src/Services/CountryCodes.php

This requires a bump to the new version of the SDK?

barryvdh added a commit to barryvdh/magento that referenced this pull request Aug 7, 2024
@barryvdh
Bump SDK version
352ac10 
Required in myparcelnl#856
@barryvdh barryvdh mentioned this pull request Aug 7, 2024
Merged
joerivanveen pushed a commit that referenced this pull request Aug 8, 2024
@barryvdh
fix: use country codes from sdk
5b1339e 
Required in #856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdieLemoine EdieLemoine EdieLemoine left review comments

@GravendeelJochem GravendeelJochem GravendeelJochem approved these changes

@joerivanveen joerivanveen joerivanveen approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@FlorianSDV @MyParcelBot @barryvdh @EdieLemoine @joerivanveen @GravendeelJochem