From 6f8d6ef58df78bd4c5ef3fc2b73407999f8d6cc3 Mon Sep 17 00:00:00 2001 From: markernst97 Date: Wed, 25 Oct 2023 09:42:42 +0200 Subject: [PATCH] fix: feedback --- config/pdk-settings.php | 6 ++++++ src/App/Action/Backend/Order/UpdateOrderStatusAction.php | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/config/pdk-settings.php b/config/pdk-settings.php index 2f6f25a12..238d126c7 100644 --- a/config/pdk-settings.php +++ b/config/pdk-settings.php @@ -6,6 +6,7 @@ use MyParcelNL\Pdk\Facade\Platform; use MyParcelNL\Pdk\Settings\Model\CarrierSettings; use MyParcelNL\Pdk\Settings\Model\CustomsSettings; +use MyParcelNL\Pdk\Settings\Model\OrderSettings; use MyParcelNL\Pdk\Settings\SettingsManager; use MyParcelNL\Pdk\Shipment\Model\DeliveryOptions; use MyParcelNL\Pdk\Shipment\Model\DropOffDay; @@ -80,6 +81,11 @@ CarrierSettings::SHOW_DELIVERY_DAY => true, ], ], + OrderSettings::ID => [ + SettingsManager::KEY_ALL => [ + OrderSettings::STATUS_ON_LABEL_CREATE => -1, + ], + ], ]; }), diff --git a/src/App/Action/Backend/Order/UpdateOrderStatusAction.php b/src/App/Action/Backend/Order/UpdateOrderStatusAction.php index 5464971b3..de2f0cef0 100644 --- a/src/App/Action/Backend/Order/UpdateOrderStatusAction.php +++ b/src/App/Action/Backend/Order/UpdateOrderStatusAction.php @@ -47,7 +47,7 @@ public function handle(Request $request): Response $status = SettingsFacade::get($settingName, OrderSettings::ID); - if (Settings::OPTION_NONE === (int) $status || null === $status) { + if (Settings::OPTION_NONE === (int) $status) { return $this->getResponse(); }