Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with TheCheckout #231

Open
zelarg opened this issue Dec 2, 2023 · 4 comments
Open

Compatibility with TheCheckout #231

zelarg opened this issue Dec 2, 2023 · 4 comments
Labels
compatibility Compatibility issues feature New feature or request pdk This is a pdk related issue

Comments

@zelarg
Copy link

zelarg commented Dec 2, 2023

Module/theme name

TheCheckout

Pricing

Premium

What problem does this feature solve?

Myparcel widget doesn't show at all when using third party checkout. With Native checkout, it displays fine.
There are no errors shown in dev tools console, widget simply does not render.

What should the solution look like?

It shall behave just like in native checkout. Solution suggestions:

  • together with checkout module developer, find out when/where myparcelnl module triggers action to populate/render widget and what could be blocking it on either side; OR
  • provide please brief information, how third party checkout could actively invoke widget rendering

Relevant log output

No response

Additional context

We're testing this with new 2.0.0-beta1 version. With older version of myparcelnl this was working OK, although some custom modification was required on checkout module (described here #153). This time around, it doesn't work at all, and event emit (updatedDeliveryForm) is not helping anymore.

What we found out - compared to native checkout - that the container .myparcelnl-delivery-options-wrapper remains empty, even though the modules/myparcelnl/views/js/frontend/checkout/dist/index.iife.js is being loaded and invoked (that suggest assets are loaded just fine). It seems that some condition is "blocking" the widget rendering.

image

It is possible also to send you this third party module should you need to test this, or setup Prestashop with myparcelnl + thecheckout module, if you're interested.
Direct contact to module developer: [email protected]

@zelarg zelarg added compatibility Compatibility issues feature New feature or request labels Dec 2, 2023
@EdieLemoine
Copy link
Contributor

Hi @zelarg, thanks for taking the time to write such a detailed issue. It might be an issue with how we detect the available shipping methods, which has a large part in determining whether it should render, but I don't have much to go off without seeing it in action.

I'm not sure if the developer would be okay with you giving us a copy of the module, we will send them an email to ask about it.

In the meantime, do you have a (test) site we could access to see what's happening in the checkout? We might be able to figure it out like that.

@EdieLemoine EdieLemoine changed the title Compatibility with third party checkout module Compatibility with TheCheckout Dec 4, 2023
@EdieLemoine EdieLemoine added the pdk This is a pdk related issue label Dec 4, 2023
@github-project-automation github-project-automation bot moved this to Todo in PDK Dec 4, 2023
@zelarg
Copy link
Author

zelarg commented Dec 4, 2023

Hi @EdieLemoine, I've send the Shop URL to Jochem G. by email. Thank you!

@mcrielaard
Copy link

I also use TheCheckout it would be great if MyParcel works in combination with this great Checkout module.

@zelarg
Copy link
Author

zelarg commented Dec 30, 2024

Is there any update to this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility issues feature New feature or request pdk This is a pdk related issue
Development

No branches or pull requests

3 participants