Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reddit.com #104335

Open
spirillen opened this issue Feb 18, 2025 · 7 comments
Open

reddit.com #104335

spirillen opened this issue Feb 18, 2025 · 7 comments

Comments

@spirillen
Copy link
Contributor

spirillen commented Feb 18, 2025

Comments

Previously committed an approved domain, used for serving Porn contents

Domain

reddit.com

Wildcard domain records

reddit.com|adult

Sub-Domain records

null

Hosts (RFC:952) specific records, not used by DNS RPZ firewalls

null

Safe Search records

null

Screenshots

Screenshot (click to expand)

N/A

Links to external sources

Name servers

ns-1029.awsdns-00.org.
ns-1887.awsdns-43.co.uk.
ns-378.awsdns-47.com.
ns-557.awsdns-05.net.

logs from uBlock Origin

N/A

@Psychpsyo
Copy link

What?

@spirillen
Copy link
Contributor Author

What?

What what?

@Psychpsyo
Copy link

What?

What what?

Why is my Ladybird issue in the "Links to external sources" in your post? (the first one)
What does it have to do with this?

@spirillen
Copy link
Contributor Author

Well the short and real answer... ask Microsoft, it's their search code that is used for finding "Related" issues.

I simply do this by using the API to search throughout Github for issue's body for contents that do match, not looks like, match the domain-name in this issue's title

        $curl_command -sL -G \
            "https://api.github.com/search/issues?q=${query}+repo:${repo}" \
            -H 'Accept: application/vnd.github.text-match+json' |
            jq '.items[ ] '"${test}"' | "+ <" + .html_url + ">"' -r
    }

You could then add a test to the replies, like this

|
            jq -r '.[] | select(.summary|test("^'"${RECORD}"'$")) |
                "+ " + .idReadable + " (<https://'"$domain"'" + "/issue/" +
                .idReadable + "/" + .summary + ">)"'

But then, you get no hits what so ever, even on exact matches. as you can see, its rather challenging as the Microsoft Bing search engine are not working as expected...

But on the other hand.. you are only the fourth person, whom made a request/reported a issue from ~104.000 generated issues.

I will of course, by your request, remove the FP.

@Psychpsyo
Copy link

Well the short and real answer... ask Microsoft, it's their search code that is used for finding "Related" issues.

So the short and real answer is "I didn't want to fill out my issue by hand so I wrote a faulty automation to do it instead"

I don't know how exactly your code included random unrelated issues from all over Github because when I query https://api.github.com/search/issues?q=reddit.com+repo:mypdns/matrix, I get a very sensible amount of data.

I'm also not asking to be removed from this issue, I'm asking you to not put "external sources" if you don't have any.
If someone wants to know if this came up before, they can easily do that search themselves without pinging random people.

@spirillen
Copy link
Contributor Author

So the short and real answer is "I didn't want to fill out my issue by hand so I wrote a faulty automation to do it instead"

That's another short yes, but... did you notice the second line of the issue? that kind a explain why

+repo:mypdns/matrix

Is only added to one of three searched 😉

they can easily do that search themselves without pinging random people.

Maybe you should read the README for the project, just a suggestion ❓

@Psychpsyo
Copy link

That's another short yes, but... did you notice the second line of the issue? that kind a explain why

That line explains why reddit belongs on this list. It does not explain your choice of external sources.

Maybe you should read the README for the project, just a suggestion ❓

Done that. Your external sources are largely about non-porn-related technical issues for things relating to reddit. Most of them seem to have little to do with why it is or isn't on any blocklists or how pornography gets shared on there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants