[Waste] [Echo] Check event before/after sending. #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4896 +/- ##
==========================================
- Coverage 82.49% 82.48% -0.01%
==========================================
Files 406 406
Lines 31716 31741 +25
Branches 5044 5053 +9
==========================================
+ Hits 26163 26183 +20
- Misses 4064 4065 +1
- Partials 1489 1493 +4 ☔ View full report in Codecov by Sentry. |
davea
approved these changes
Mar 27, 2024
dracos
force-pushed
the
echo-check-event-firs
branch
from
d959c49 to
e7ffa72
Compare
dracos
force-pushed
the
echo-check-event-firs
branch
from
e7ffa72 to
e9d0f3f
Compare
If we get an internal error from Echo when sending, try and look up the event directly to see if it has actually been created. Also do the same before sending as an extra check.
dracos
force-pushed
the
echo-check-event-firs
branch
from
e9d0f3f to
4c4da0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we get an internal error from Echo when sending, try and look up the event directly to see if it has actually been created. Also do the same before sending as an extra check. [skip changelog]