Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merton] Bin not being returned correctly and waste spillage #5252

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

MorayMySoc
Copy link
Contributor

@MorayMySoc MorayMySoc commented Nov 12, 2024

Part 1 of MRT167 Set up remaining processes in WW

Allow residents to select specified bin types to report a problem that bins haven't been returned correctly to the correct location or have been left open.

These reports allow a request for the bin collectors to return and rectify the issue along with a notes field

Waste spillage can be reported just with a notes field.

To make live: Check category details on servers with same branch name are live and merge this

https://github.com/mysociety/societyworks/issues/4593

[skip changelog]

@MorayMySoc MorayMySoc requested a review from dracos November 12, 2024 10:48
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.74%. Comparing base (182f35b) to head (d6d4657).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Merton/Waste.pm 50.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5252      +/-   ##
==========================================
+ Coverage   82.41%   82.74%   +0.33%     
==========================================
  Files         409      409              
  Lines       32073    32802     +729     
  Branches     5118     5306     +188     
==========================================
+ Hits        26432    27142     +710     
- Misses       4122     4133      +11     
- Partials     1519     1527       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few small things :)

templates/email/default/waste/other-reported.html Outdated Show resolved Hide resolved
templates/email/default/waste/other-reported.txt Outdated Show resolved Hide resolved
templates/web/merton/waste/enquiry-problem.html Outdated Show resolved Hide resolved
t/app/controller/waste_merton.t Show resolved Hide resolved
templates/web/base/waste/services.html Outdated Show resolved Hide resolved
@MorayMySoc MorayMySoc requested a review from dracos November 12, 2024 13:00
@MorayMySoc
Copy link
Contributor Author

Forgot to say, config is in same branch on servers...

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot

Part 1 of MRT167 Set up remaining processes in WW

Allow residents to select specified bin types to report
a problem that bins haven't been returned correctly
to the correct  location or have been left open.

These reports allow a request for the bin collectors
to return and rectify the issue along with a notes field

Waste spillage can be reported just with a notes field.

Category details on servers with same branch name.

mysociety/societyworks#4593
@dracos dracos force-pushed the 4593-merton-waste-spillage branch from d6d4657 to fbbc68c Compare December 11, 2024 11:19
@dracos dracos merged commit fbbc68c into master Dec 11, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants