Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shropshire] Amendments from workshop #5265

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

davea
Copy link
Member

@davea davea commented Nov 21, 2024

A few changes as a result of the workshop we held with Shropshire:

  • Pin colours
  • Enable Street Manager

For FD-????

[skip changelog]

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.41%. Comparing base (6f72070) to head (77658be).

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Borsetshire.pm 20.00% 4 Missing ⚠️
perllib/FixMyStreet/Cobrand/Shropshire.pm 40.00% 1 Missing and 2 partials ⚠️
perllib/FixMyStreet/Cobrand/Buckinghamshire.pm 80.00% 0 Missing and 1 partial ⚠️
perllib/FixMyStreet/Cobrand/Gloucestershire.pm 75.00% 0 Missing and 1 partial ⚠️
web/cobrands/oxfordshire/assets.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5265   +/-   ##
=======================================
  Coverage   82.40%   82.41%           
=======================================
  Files         415      415           
  Lines       32833    32839    +6     
  Branches     5265     5267    +2     
=======================================
+ Hits        27055    27063    +8     
+ Misses       4222     4218    -4     
- Partials     1556     1558    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dracos and others added 3 commits December 12, 2024 20:50
This puts them all under web/i/pins, one directory per 'colour',
path_to_pin_icons is only used for sourcing shadow/spot files.
Not confirmed yet, just for comment.
@dracos dracos force-pushed the shropshire-workshop-fixes branch from 46a50af to 77658be Compare December 12, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants