diff --git a/docs/directory_structure.md b/docs/directory_structure.md index a8b8955d55..d318fadf6a 100644 --- a/docs/directory_structure.md +++ b/docs/directory_structure.md @@ -297,7 +297,7 @@ you're doing is [customising your installation](/customising).

images

Images, including navigation icons and sprites, used by the default site (and hence - available to other cobrands too) — for example pin-green.png + available to other cobrands too) — for example pins/green/pin.png is the green pin used on most cobrand's maps.

diff --git a/perllib/FixMyStreet/Cobrand/Borsetshire.pm b/perllib/FixMyStreet/Cobrand/Borsetshire.pm index 1d289b1fde..d3920e355e 100644 --- a/perllib/FixMyStreet/Cobrand/Borsetshire.pm +++ b/perllib/FixMyStreet/Cobrand/Borsetshire.pm @@ -16,15 +16,13 @@ sub enter_postcode_text { sub pin_colour { my ( $self, $p, $context ) = @_; - return 'grey' if $p->is_closed; - return 'green' if $p->is_fixed; - return 'yellow' if $p->state eq 'confirmed'; - return 'orange'; # all the other `open_states` like "in progress" + return 'grey-cross' if $p->is_closed; + return 'green-tick' if $p->is_fixed; + return 'yellow-cone' if $p->state eq 'confirmed'; + return 'orange-work'; # all the other `open_states` like "in progress" } -sub path_to_pin_icons { - return '/cobrands/oxfordshire/images/'; -} +sub path_to_pin_icons { '/i/pins/whole-shadow-cone-spot/' } sub send_questionnaires { 0 } diff --git a/perllib/FixMyStreet/Cobrand/Brent.pm b/perllib/FixMyStreet/Cobrand/Brent.pm index 6582f12d7b..e12563a819 100644 --- a/perllib/FixMyStreet/Cobrand/Brent.pm +++ b/perllib/FixMyStreet/Cobrand/Brent.pm @@ -78,9 +78,7 @@ my $BRENT_CONTAINERS = { =cut -sub path_to_pin_icons { - return '/cobrands/oxfordshire/images/'; -} +sub path_to_pin_icons { '/i/pins/whole-shadow-cone-spot/' } =item * Users with a brent.gov.uk email can always be found in the admin. @@ -320,10 +318,10 @@ sub munge_cobrand_asset_categories { sub pin_colour { my ( $self, $p, $context ) = @_; - return 'grey' if $p->is_closed; - return 'green' if $p->is_fixed; - return 'yellow' if $p->state eq 'confirmed'; - return 'orange'; # all the other `open_states` like "in progress" + return 'grey-cross' if $p->is_closed; + return 'green-tick' if $p->is_fixed; + return 'yellow-cone' if $p->state eq 'confirmed'; + return 'orange-work'; # all the other `open_states` like "in progress" } =head2 categories_restriction diff --git a/perllib/FixMyStreet/Cobrand/Buckinghamshire.pm b/perllib/FixMyStreet/Cobrand/Buckinghamshire.pm index 4367d3e762..8e71bc4fc3 100644 --- a/perllib/FixMyStreet/Cobrand/Buckinghamshire.pm +++ b/perllib/FixMyStreet/Cobrand/Buckinghamshire.pm @@ -87,15 +87,13 @@ sub around_nearby_filter { sub pin_colour { my ( $self, $p, $context ) = @_; - return 'grey' if $p->is_closed || ($context ne 'reports' && !$self->owns_problem($p)); - return 'green' if $p->is_fixed; - return 'yellow' if $p->state eq 'confirmed'; - return 'orange'; # all the other `open_states` like "in progress" + return 'grey-cross' if $p->is_closed || ($context ne 'reports' && !$self->owns_problem($p)); + return 'green-tick' if $p->is_fixed; + return 'yellow-cone' if $p->state eq 'confirmed'; + return 'orange-work'; # all the other `open_states` like "in progress" } -sub path_to_pin_icons { - return '/cobrands/oxfordshire/images/'; -} +sub path_to_pin_icons { '/i/pins/whole-shadow-cone-spot/' } sub admin_user_domain { ( 'buckscc.gov.uk', 'buckinghamshire.gov.uk' ) } diff --git a/perllib/FixMyStreet/Cobrand/Default.pm b/perllib/FixMyStreet/Cobrand/Default.pm index c8b89ef3a8..31e9f56171 100644 --- a/perllib/FixMyStreet/Cobrand/Default.pm +++ b/perllib/FixMyStreet/Cobrand/Default.pm @@ -1090,10 +1090,7 @@ for your cobrand. =cut -sub path_to_pin_icons { - return '/i/'; -} - +sub path_to_pin_icons { '/i/pins/' } =item tweak_all_reports_map diff --git a/perllib/FixMyStreet/Cobrand/Gloucestershire.pm b/perllib/FixMyStreet/Cobrand/Gloucestershire.pm index 6df2483406..29612ada1e 100644 --- a/perllib/FixMyStreet/Cobrand/Gloucestershire.pm +++ b/perllib/FixMyStreet/Cobrand/Gloucestershire.pm @@ -257,14 +257,12 @@ apart from defects which are blue. sub pin_colour { my ( $self, $p ) = @_; - return 'defects' if $self->is_defect($p); - return 'green' if $p->is_fixed || $p->is_closed; - return 'yellow'; + return 'blue-work' if $self->is_defect($p); + return 'green-tick' if $p->is_fixed || $p->is_closed; + return 'yellow-cone'; } -sub path_to_pin_icons { - return '/cobrands/oxfordshire/images/'; -} +sub path_to_pin_icons { '/i/pins/whole-shadow-cone-spot/' } =head2 open311_config diff --git a/perllib/FixMyStreet/Cobrand/Northumberland.pm b/perllib/FixMyStreet/Cobrand/Northumberland.pm index cc5f1beb7e..0e9632b261 100644 --- a/perllib/FixMyStreet/Cobrand/Northumberland.pm +++ b/perllib/FixMyStreet/Cobrand/Northumberland.pm @@ -74,10 +74,6 @@ sub pin_colour { return 'orange'; # all the other `open_states` like "in progress" } -sub path_to_pin_icons { - return '/cobrands/northumberland/images/'; -} - =item * Hovering over a pin includes the state as well as the title =cut diff --git a/perllib/FixMyStreet/Cobrand/Oxfordshire.pm b/perllib/FixMyStreet/Cobrand/Oxfordshire.pm index 061d07bde5..0e38300957 100644 --- a/perllib/FixMyStreet/Cobrand/Oxfordshire.pm +++ b/perllib/FixMyStreet/Cobrand/Oxfordshire.pm @@ -85,20 +85,18 @@ sub reports_ordering { sub pin_colour { my ( $self, $p, $context ) = @_; - return 'grey' if ($context||'') ne 'reports' && !$self->owns_problem($p); - return 'grey' if $p->is_closed; - return 'green' if $p->is_fixed; - return 'yellow' if $p->state eq 'confirmed'; - return 'orange'; # all the other `open_states` like "in progress" + return 'grey-cross' if ($context||'') ne 'reports' && !$self->owns_problem($p); + return 'grey-cross' if $p->is_closed; + return 'green-tick' if $p->is_fixed; + return 'yellow-cone' if $p->state eq 'confirmed'; + return 'orange-work'; # all the other `open_states` like "in progress" } sub pin_new_report_colour { - return 'yellow'; + return 'yellow-cone'; } -sub path_to_pin_icons { - return '/cobrands/oxfordshire/images/'; -} +sub path_to_pin_icons { '/i/pins/whole-shadow-cone-spot/' } sub pin_hover_title { my ($self, $problem, $title) = @_; @@ -494,7 +492,7 @@ sub pins_from_wfs { id => $fake_id--, latitude => @$coords[1], longitude => @$coords[0], - colour => 'defects', + colour => 'blue-work', title => $title, }; } @{ $wfs->{features} }; diff --git a/perllib/FixMyStreet/Cobrand/Shropshire.pm b/perllib/FixMyStreet/Cobrand/Shropshire.pm index 074503837b..bf96a6ac59 100644 --- a/perllib/FixMyStreet/Cobrand/Shropshire.pm +++ b/perllib/FixMyStreet/Cobrand/Shropshire.pm @@ -199,4 +199,21 @@ sub dashboard_export_problems_add_columns { }); } +=head2 pin_colour + +Green for completed or closed, yellow for open, +blue for anything else (in progress, action scheduled, etc) + +=cut + +sub pin_colour { + my ( $self, $p ) = @_; + + return 'green-tick' if $p->is_fixed || $p->is_closed; + return 'yellow-cone' if $p->state eq 'confirmed'; + return 'blue-work'; +} + +sub path_to_pin_icons { '/i/pins/whole-shadow-cone-spot/' } + 1; diff --git a/perllib/FixMyStreet/DB/Result/Problem.pm b/perllib/FixMyStreet/DB/Result/Problem.pm index 96ece1476d..cb2be88cf3 100644 --- a/perllib/FixMyStreet/DB/Result/Problem.pm +++ b/perllib/FixMyStreet/DB/Result/Problem.pm @@ -1336,7 +1336,7 @@ sub static_map { my $pin = $map_data->{pins}->[0]; if ($pin) { my $im = Image::Magick->new; - $im->read(FixMyStreet->path_to('web', 'i', 'pin-yellow.png')); + $im->read(FixMyStreet->path_to('web', 'i', 'pins/yellow/pin.png')); $im->Scale( geometry => '48x64' ); $image->Composite(image => $im, gravity => 'NorthWest', x => $pin->{px} - 24, y => $pin->{py} - 64); diff --git a/t/app/controller/admin/report_edit.t b/t/app/controller/admin/report_edit.t index d7db221fa6..41a2c59f14 100644 --- a/t/app/controller/admin/report_edit.t +++ b/t/app/controller/admin/report_edit.t @@ -394,7 +394,7 @@ foreach my $test ( } if ($report->state eq 'fixed') { - $mech->content_contains('pin-green'); + $mech->content_contains('pins/green'); } $test->{changes}->{flagged} = 1 if $test->{changes}->{flagged}; diff --git a/t/app/controller/around.t b/t/app/controller/around.t index 9cac4f41c3..a48254a5d7 100644 --- a/t/app/controller/around.t +++ b/t/app/controller/around.t @@ -570,7 +570,7 @@ subtest 'check nearby lookup, cobrand custom distances' => sub { . '&filter_category=Pothole' . ( $test->{mode} ? '&mode=' . $test->{mode} : '' ) ); - $mech->contains_or_lacks($test->{contains}, '[51.754926,-1.256179,"yellow",' . $p->id . ',"Open: Around page Test 1 for ' . $body->id . '","small",false]'); + $mech->contains_or_lacks($test->{contains}, '[51.754926,-1.256179,"yellow-cone",' . $p->id . ',"Open: Around page Test 1 for ' . $body->id . '","small",false]'); } }; }; @@ -639,7 +639,7 @@ subtest 'check nearby lookup, cobrand custom distances per category' => sub { note ' Check for problem ' . $test_p->{id}; $mech->contains_or_lacks( $test->{contains} && $test_p->{captured_by_category_filters}, - '[51.754926,-1.256179,"yellow",' + '[51.754926,-1.256179,"yellow-cone",' . $test_p->{id} . ',"Open: Around page Test 1 for ' . $body->id @@ -670,7 +670,7 @@ subtest 'check nearby lookup, cobrand custom distances per category' => sub { note ' Check for problem ' . $test_p->{id}; $mech->contains_or_lacks( $test->{contains} && $test_p->{captured_by_category_filters}, - '[51.754926,-1.256179,"yellow",' + '[51.754926,-1.256179,"yellow-cone",' . $test_p->{id} . ',"Open: Around page Test 1 for ' . $body->id @@ -701,7 +701,7 @@ subtest 'check nearby lookup, cobrand custom distances per category' => sub { note 'Check for problem ' . $test_p->{id}; $mech->contains_or_lacks( $test->{contains} && $test_p->{captured_by_category_filters}, - '[51.754926,-1.256179,"yellow",' + '[51.754926,-1.256179,"yellow-cone",' . $test_p->{id} . ',"Open: Around page Test 1 for ' . $body->id diff --git a/t/cobrand/brent.t b/t/cobrand/brent.t index 65ed4ecd14..502c5fab54 100644 --- a/t/cobrand/brent.t +++ b/t/cobrand/brent.t @@ -500,16 +500,16 @@ FixMyStreet::override_config { }); $problem->state('confirmed'); - is $cobrand->pin_colour($problem, 'around'), 'yellow', 'confirmed problem has correct pin colour'; + is $cobrand->pin_colour($problem, 'around'), 'yellow-cone', 'confirmed problem has correct pin colour'; $problem->state('closed'); - is $cobrand->pin_colour($problem, 'around'), 'grey', 'closed problem has correct pin colour'; + is $cobrand->pin_colour($problem, 'around'), 'grey-cross', 'closed problem has correct pin colour'; $problem->state('fixed'); - is $cobrand->pin_colour($problem, 'around'), 'green', 'fixed problem has correct pin colour'; + is $cobrand->pin_colour($problem, 'around'), 'green-tick', 'fixed problem has correct pin colour'; $problem->state('in_progress'); - is $cobrand->pin_colour($problem, 'around'), 'orange', 'in_progress problem has correct pin colour'; + is $cobrand->pin_colour($problem, 'around'), 'orange-work', 'in_progress problem has correct pin colour'; }; }; diff --git a/templates/web/base/maps/pin.html b/templates/web/base/maps/pin.html index 78e6470466..03d68b2c96 100644 --- a/templates/web/base/maps/pin.html +++ b/templates/web/base/maps/pin.html @@ -2,7 +2,7 @@ [% IF pin.id AND pin.problem %] [%- END -%] -

- + [% text %]

diff --git a/templates/web/bromley/report/banner.html b/templates/web/bromley/report/banner.html index 63771ea3b7..d88ffd4759 100644 --- a/templates/web/bromley/report/banner.html +++ b/templates/web/bromley/report/banner.html @@ -3,7 +3,7 @@ [% BLOCK banner %] diff --git a/templates/web/fixmystreet-uk-councils/report/banner.html b/templates/web/fixmystreet-uk-councils/report/banner.html index 013490842d..ccd5927897 100644 --- a/templates/web/fixmystreet-uk-councils/report/banner.html +++ b/templates/web/fixmystreet-uk-councils/report/banner.html @@ -3,7 +3,7 @@ [% BLOCK banner %] diff --git a/templates/web/fixmystreet.com/report/banner.html b/templates/web/fixmystreet.com/report/banner.html index 5eeabe2ac7..9efc0ac69d 100644 --- a/templates/web/fixmystreet.com/report/banner.html +++ b/templates/web/fixmystreet.com/report/banner.html @@ -3,7 +3,7 @@ [% BLOCK banner %] diff --git a/templates/web/shropshire/footer_extra_js.html b/templates/web/shropshire/footer_extra_js.html index 88fc006e76..12a42c0d24 100644 --- a/templates/web/shropshire/footer_extra_js.html +++ b/templates/web/shropshire/footer_extra_js.html @@ -1 +1 @@ -[% PROCESS 'footer_extra_js_base.html' highways=1 validation=1 %] +[% PROCESS 'footer_extra_js_base.html' highways=1 validation=1 roadworks=1 %] diff --git a/web/cobrands/brent/_variables.scss b/web/cobrands/brent/_variables.scss index 233bf1ede1..424f9544d6 100644 --- a/web/cobrands/brent/_variables.scss +++ b/web/cobrands/brent/_variables.scss @@ -70,8 +70,6 @@ $nav_hover_background_colour: $primary; $header-top-border: false; -$pin_prefix: '/cobrands/brent/images/'; - $col_click_map: $gray-1; $col_click_map_dark: darken($gray-1, 10%); diff --git a/web/cobrands/fixmystreet/assets.js b/web/cobrands/fixmystreet/assets.js index 06ca9ce195..8cf413afb1 100644 --- a/web/cobrands/fixmystreet/assets.js +++ b/web/cobrands/fixmystreet/assets.js @@ -881,7 +881,7 @@ function construct_hover_feature_control(asset_layers, options) { // fixmystreet.pin_prefix isn't always available here, due // to file loading order, so get it from the DOM directly. var map_data = document.getElementById('js-map-data'); -var pin_prefix = fixmystreet.pin_prefix || (map_data ? map_data.getAttribute('data-pin_prefix') : '/i/'); +var pin_prefix = fixmystreet.pin_prefix || (map_data ? map_data.getAttribute('data-pin_prefix') : '/i/pins/'); fixmystreet.assets = { layers: [], @@ -914,13 +914,13 @@ fixmystreet.assets = { }), style_default_select: new OpenLayers.Style({ - externalGraphic: pin_prefix + "pin-spot.png", + externalGraphic: pin_prefix + "spot.png", fillColor: "#55BB00", graphicWidth: 48, graphicHeight: 64, graphicXOffset: -24, graphicYOffset: -56, - backgroundGraphic: pin_prefix + "pin-shadow.png", + backgroundGraphic: pin_prefix + "shadow/pin.png", backgroundWidth: 60, backgroundHeight: 30, backgroundXOffset: -7, diff --git a/web/cobrands/fixmystreet/fixmystreet.js b/web/cobrands/fixmystreet/fixmystreet.js index 1a92cf0663..9c1ac4cdd8 100644 --- a/web/cobrands/fixmystreet/fixmystreet.js +++ b/web/cobrands/fixmystreet/fixmystreet.js @@ -382,11 +382,7 @@ fixmystreet.set_up = fixmystreet.set_up || {}; $.extend(fixmystreet.set_up, { basics: function() { // Preload the new report pin - if ( typeof fixmystreet !== 'undefined' && typeof fixmystreet.pin_prefix !== 'undefined' ) { - document.createElement('img').src = fixmystreet.pin_prefix + 'pin-' + fixmystreet.pin_new_report_colour + '.png'; - } else { - document.createElement('img').src = '/i/pin-green.png'; - } + document.createElement('img').src = '/i/pins/' + (fixmystreet.pin_new_report_colour || 'green') + '/pin.png'; $('a[href*="around"]').each(function() { this.href = this.href + (this.href.indexOf('?') > -1 ? '&js=1' : '?js=1'); diff --git a/web/cobrands/oxfordshire/_colours.scss b/web/cobrands/oxfordshire/_colours.scss index 2b70b1e356..e5555ac189 100644 --- a/web/cobrands/oxfordshire/_colours.scss +++ b/web/cobrands/oxfordshire/_colours.scss @@ -42,8 +42,6 @@ $header-top-border: false; $form-control-border-color: #525252; -$pin_prefix: '/cobrands/oxfordshire/images/'; - $search-help-alignment: left; $search-help-background: #fff3f3; $search-help-margin-desktop: -2em 0 0 0; diff --git a/web/cobrands/oxfordshire/assets.js b/web/cobrands/oxfordshire/assets.js index 550815627d..77957833e3 100644 --- a/web/cobrands/oxfordshire/assets.js +++ b/web/cobrands/oxfordshire/assets.js @@ -57,7 +57,7 @@ function setup_defect_popup() { hover: true, clickFeature: function (feature) { close_defect_popup(); - if (feature.attributes.colour !== 'defects') { + if (feature.attributes.colour !== 'blue-work') { // We're only interested in defects return; } diff --git a/web/cobrands/oxfordshire/base.scss b/web/cobrands/oxfordshire/base.scss index 216aabf25c..4ae2f71425 100644 --- a/web/cobrands/oxfordshire/base.scss +++ b/web/cobrands/oxfordshire/base.scss @@ -387,5 +387,24 @@ textarea { } } +// Like .item-list__item--indented except with a pin icon baked in! +.item-list__item--with-pin { + a { + background-image: url('/i/pins/yellow-cone/small.png'); + } + &.yellow-cone a { + background-image: url('/i/pins/yellow-cone/small.png'); + } + &.green-tick a { + background-image: url('/i/pins/green-tick/small.png'); + } + &.grey-cross a { + background-image: url('/i/pins/grey-cross/small.png'); + } + &.orange-work a { + background-image: url('/i/pins/orange-work/small.png'); + } +} + @import "oxfordshire-footer"; @import "oxfordshire-cookiepopup"; diff --git a/web/cobrands/oxfordshire/images/pin-grey-big.png b/web/cobrands/oxfordshire/images/pin-grey-big.png deleted file mode 100644 index 324195e51d..0000000000 Binary files a/web/cobrands/oxfordshire/images/pin-grey-big.png and /dev/null differ diff --git a/web/cobrands/oxfordshire/images/pin-grey-mini.png b/web/cobrands/oxfordshire/images/pin-grey-mini.png deleted file mode 100644 index 266d8f1858..0000000000 Binary files a/web/cobrands/oxfordshire/images/pin-grey-mini.png and /dev/null differ diff --git a/web/cobrands/oxfordshire/images/pin-grey-small.png b/web/cobrands/oxfordshire/images/pin-grey-small.png deleted file mode 100644 index 3c5893396c..0000000000 Binary files a/web/cobrands/oxfordshire/images/pin-grey-small.png and /dev/null differ diff --git a/web/cobrands/oxfordshire/images/pin-grey.png b/web/cobrands/oxfordshire/images/pin-grey.png deleted file mode 100644 index 89d03b6f24..0000000000 Binary files a/web/cobrands/oxfordshire/images/pin-grey.png and /dev/null differ diff --git a/web/cobrands/sass/_layout.scss b/web/cobrands/sass/_layout.scss index 174f5eb853..c6450119d7 100644 --- a/web/cobrands/sass/_layout.scss +++ b/web/cobrands/sass/_layout.scss @@ -1055,7 +1055,7 @@ textarea.form-error { .keyboard-pin { display: none; - background-image: url('/i/pin-green-big.png'); + background-image: url('/i/pins/green/big.png'); background-size: contain; background-repeat: no-repeat; background-position: center; @@ -1070,7 +1070,7 @@ textarea.form-error { &::after { content: ""; - background-image: url('/i/pin-shadow-big.png'); + background-image: url('/i/pins/shadow/big.png'); background-size: contain; background-repeat: no-repeat; width: 88px; diff --git a/web/cobrands/sass/_report_list_pins.scss b/web/cobrands/sass/_report_list_pins.scss index f4140f1533..97a994f8a7 100644 --- a/web/cobrands/sass/_report_list_pins.scss +++ b/web/cobrands/sass/_report_list_pins.scss @@ -1,30 +1,28 @@ -$pin_prefix: '/i/' !default; - // Like .item-list__item--indented except with a pin icon baked in! .item-list__item--with-pin { @extend .item-list__item--indented; a { - background-image: url('#{$pin_prefix}pin-yellow-small.png'); + background-image: url('/i/pins/yellow/small.png'); background-size: 24px 32px; background-repeat: no-repeat; background-position: $left center; } &.yellow a { - background-image: url('#{$pin_prefix}pin-yellow-small.png'); + background-image: url('/i/pins/yellow/small.png'); } &.green a { - background-image: url('#{$pin_prefix}pin-green-small.png'); + background-image: url('/i/pins/green/small.png'); } &.red a { - background-image: url('#{$pin_prefix}pin-red-small.png'); + background-image: url('/i/pins/red/small.png'); } &.grey a { - background-image: url('#{$pin_prefix}pin-grey-small.png'); + background-image: url('/i/pins/grey/small.png'); } &.orange a { - background-image: url('#{$pin_prefix}pin-orange-small.png'); + background-image: url('/i/pins/orange/small.png'); } } .item-list__item--selected { diff --git a/web/i/pin-blue-big.png b/web/i/pin-blue-big.png deleted file mode 100644 index e820840826..0000000000 Binary files a/web/i/pin-blue-big.png and /dev/null differ diff --git a/web/i/pin-blue-mini.png b/web/i/pin-blue-mini.png deleted file mode 100644 index a8edbb6313..0000000000 Binary files a/web/i/pin-blue-mini.png and /dev/null differ diff --git a/web/i/pin-blue-small.png b/web/i/pin-blue-small.png deleted file mode 100644 index 699a8226cb..0000000000 Binary files a/web/i/pin-blue-small.png and /dev/null differ diff --git a/web/i/pin-blue.png b/web/i/pin-blue.png deleted file mode 100644 index 2eaf9e5896..0000000000 Binary files a/web/i/pin-blue.png and /dev/null differ diff --git a/web/i/pin-green-big.png b/web/i/pin-green-big.png deleted file mode 100644 index 3eab8da11a..0000000000 Binary files a/web/i/pin-green-big.png and /dev/null differ diff --git a/web/i/pin-green-mini.png b/web/i/pin-green-mini.png deleted file mode 100644 index 6497e53e8e..0000000000 Binary files a/web/i/pin-green-mini.png and /dev/null differ diff --git a/web/i/pin-green-small.png b/web/i/pin-green-small.png deleted file mode 100644 index ee7f8514bd..0000000000 Binary files a/web/i/pin-green-small.png and /dev/null differ diff --git a/web/i/pin-green.png b/web/i/pin-green.png deleted file mode 100644 index 83068d86c6..0000000000 Binary files a/web/i/pin-green.png and /dev/null differ diff --git a/web/i/pin-orange-big.png b/web/i/pin-orange-big.png deleted file mode 100644 index a7597d6b30..0000000000 Binary files a/web/i/pin-orange-big.png and /dev/null differ diff --git a/web/i/pin-orange-mini.png b/web/i/pin-orange-mini.png deleted file mode 100644 index 546f00e0a4..0000000000 Binary files a/web/i/pin-orange-mini.png and /dev/null differ diff --git a/web/i/pin-orange-small.png b/web/i/pin-orange-small.png deleted file mode 100644 index 7f866fd126..0000000000 Binary files a/web/i/pin-orange-small.png and /dev/null differ diff --git a/web/i/pin-orange.png b/web/i/pin-orange.png deleted file mode 100644 index 5e33e8010c..0000000000 Binary files a/web/i/pin-orange.png and /dev/null differ diff --git a/web/i/pin-red-big.png b/web/i/pin-red-big.png deleted file mode 100644 index 7c02b70296..0000000000 Binary files a/web/i/pin-red-big.png and /dev/null differ diff --git a/web/i/pin-red-mini.png b/web/i/pin-red-mini.png deleted file mode 100644 index 333d6a8c7a..0000000000 Binary files a/web/i/pin-red-mini.png and /dev/null differ diff --git a/web/i/pin-red-small.png b/web/i/pin-red-small.png deleted file mode 100644 index 2388ce03ef..0000000000 Binary files a/web/i/pin-red-small.png and /dev/null differ diff --git a/web/i/pin-red.png b/web/i/pin-red.png deleted file mode 100644 index 6ad0b1eeac..0000000000 Binary files a/web/i/pin-red.png and /dev/null differ diff --git a/web/i/pin-shadow-big.png b/web/i/pin-shadow-big.png deleted file mode 100644 index a65014a82c..0000000000 Binary files a/web/i/pin-shadow-big.png and /dev/null differ diff --git a/web/i/pin-shadow-small.png b/web/i/pin-shadow-small.png deleted file mode 100644 index fa5e65b5bb..0000000000 Binary files a/web/i/pin-shadow-small.png and /dev/null differ diff --git a/web/i/pin-shadow.png b/web/i/pin-shadow.png deleted file mode 100644 index 9a1f24ee7c..0000000000 Binary files a/web/i/pin-shadow.png and /dev/null differ diff --git a/web/i/pin-spot.png b/web/i/pin-spot.png deleted file mode 100644 index 43726fb48f..0000000000 Binary files a/web/i/pin-spot.png and /dev/null differ diff --git a/web/i/pin-yellow-big.png b/web/i/pin-yellow-big.png deleted file mode 100644 index 435f520b98..0000000000 Binary files a/web/i/pin-yellow-big.png and /dev/null differ diff --git a/web/i/pin-yellow-mini.png b/web/i/pin-yellow-mini.png deleted file mode 100644 index 7cbe0d09db..0000000000 Binary files a/web/i/pin-yellow-mini.png and /dev/null differ diff --git a/web/i/pin-yellow-small.png b/web/i/pin-yellow-small.png deleted file mode 100644 index 1e0235989c..0000000000 Binary files a/web/i/pin-yellow-small.png and /dev/null differ diff --git a/web/i/pin-yellow.png b/web/i/pin-yellow.png deleted file mode 100644 index 4fdaa7214c..0000000000 Binary files a/web/i/pin-yellow.png and /dev/null differ diff --git a/web/cobrands/oxfordshire/images/pin-defects-big.png b/web/i/pins/blue-work/big.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-defects-big.png rename to web/i/pins/blue-work/big.png diff --git a/web/cobrands/oxfordshire/images/pin-defects-mini.png b/web/i/pins/blue-work/mini.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-defects-mini.png rename to web/i/pins/blue-work/mini.png diff --git a/web/cobrands/oxfordshire/images/pin-defects-small.png b/web/i/pins/blue-work/pin.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-defects-small.png rename to web/i/pins/blue-work/pin.png diff --git a/web/cobrands/oxfordshire/images/pin-defects.png b/web/i/pins/blue-work/small.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-defects.png rename to web/i/pins/blue-work/small.png diff --git a/web/cobrands/northumberland/images/pin-blue-big.png b/web/i/pins/blue/big.png similarity index 100% rename from web/cobrands/northumberland/images/pin-blue-big.png rename to web/i/pins/blue/big.png diff --git a/web/cobrands/northumberland/images/pin-blue-mini.png b/web/i/pins/blue/mini.png similarity index 100% rename from web/cobrands/northumberland/images/pin-blue-mini.png rename to web/i/pins/blue/mini.png diff --git a/web/cobrands/northumberland/images/pin-blue.png b/web/i/pins/blue/pin.png similarity index 100% rename from web/cobrands/northumberland/images/pin-blue.png rename to web/i/pins/blue/pin.png diff --git a/web/cobrands/northumberland/images/pin-blue-small.png b/web/i/pins/blue/small.png similarity index 100% rename from web/cobrands/northumberland/images/pin-blue-small.png rename to web/i/pins/blue/small.png diff --git a/web/cobrands/oxfordshire/images/pin-green-big.png b/web/i/pins/green-tick/big.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-green-big.png rename to web/i/pins/green-tick/big.png diff --git a/web/cobrands/oxfordshire/images/pin-green-mini.png b/web/i/pins/green-tick/mini.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-green-mini.png rename to web/i/pins/green-tick/mini.png diff --git a/web/cobrands/oxfordshire/images/pin-green.png b/web/i/pins/green-tick/pin.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-green.png rename to web/i/pins/green-tick/pin.png diff --git a/web/cobrands/oxfordshire/images/pin-green-small.png b/web/i/pins/green-tick/small.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-green-small.png rename to web/i/pins/green-tick/small.png diff --git a/web/cobrands/northumberland/images/pin-green-big.png b/web/i/pins/green/big.png similarity index 100% rename from web/cobrands/northumberland/images/pin-green-big.png rename to web/i/pins/green/big.png diff --git a/web/cobrands/northumberland/images/pin-green-mini.png b/web/i/pins/green/mini.png similarity index 100% rename from web/cobrands/northumberland/images/pin-green-mini.png rename to web/i/pins/green/mini.png diff --git a/web/cobrands/northumberland/images/pin-green.png b/web/i/pins/green/pin.png similarity index 100% rename from web/cobrands/northumberland/images/pin-green.png rename to web/i/pins/green/pin.png diff --git a/web/cobrands/northumberland/images/pin-green-small.png b/web/i/pins/green/small.png similarity index 100% rename from web/cobrands/northumberland/images/pin-green-small.png rename to web/i/pins/green/small.png diff --git a/web/cobrands/northumberland/images/pin-grey-big.png b/web/i/pins/grey-cross/big.png similarity index 100% rename from web/cobrands/northumberland/images/pin-grey-big.png rename to web/i/pins/grey-cross/big.png diff --git a/web/cobrands/northumberland/images/pin-grey-mini.png b/web/i/pins/grey-cross/mini.png similarity index 100% rename from web/cobrands/northumberland/images/pin-grey-mini.png rename to web/i/pins/grey-cross/mini.png diff --git a/web/cobrands/northumberland/images/pin-grey.png b/web/i/pins/grey-cross/pin.png similarity index 100% rename from web/cobrands/northumberland/images/pin-grey.png rename to web/i/pins/grey-cross/pin.png diff --git a/web/cobrands/northumberland/images/pin-grey-small.png b/web/i/pins/grey-cross/small.png similarity index 100% rename from web/cobrands/northumberland/images/pin-grey-small.png rename to web/i/pins/grey-cross/small.png diff --git a/web/i/pin-grey-big.png b/web/i/pins/grey/big.png similarity index 100% rename from web/i/pin-grey-big.png rename to web/i/pins/grey/big.png diff --git a/web/i/pin-grey-mini.png b/web/i/pins/grey/mini.png similarity index 100% rename from web/i/pin-grey-mini.png rename to web/i/pins/grey/mini.png diff --git a/web/i/pin-grey.png b/web/i/pins/grey/pin.png similarity index 100% rename from web/i/pin-grey.png rename to web/i/pins/grey/pin.png diff --git a/web/i/pin-grey-small.png b/web/i/pins/grey/small.png similarity index 100% rename from web/i/pin-grey-small.png rename to web/i/pins/grey/small.png diff --git a/web/cobrands/oxfordshire/images/pin-orange-big.png b/web/i/pins/orange-work/big.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-orange-big.png rename to web/i/pins/orange-work/big.png diff --git a/web/cobrands/oxfordshire/images/pin-orange-mini.png b/web/i/pins/orange-work/mini.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-orange-mini.png rename to web/i/pins/orange-work/mini.png diff --git a/web/cobrands/oxfordshire/images/pin-orange.png b/web/i/pins/orange-work/pin.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-orange.png rename to web/i/pins/orange-work/pin.png diff --git a/web/cobrands/oxfordshire/images/pin-orange-small.png b/web/i/pins/orange-work/small.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-orange-small.png rename to web/i/pins/orange-work/small.png diff --git a/web/cobrands/northumberland/images/pin-orange-big.png b/web/i/pins/orange/big.png similarity index 100% rename from web/cobrands/northumberland/images/pin-orange-big.png rename to web/i/pins/orange/big.png diff --git a/web/cobrands/northumberland/images/pin-orange-mini.png b/web/i/pins/orange/mini.png similarity index 100% rename from web/cobrands/northumberland/images/pin-orange-mini.png rename to web/i/pins/orange/mini.png diff --git a/web/cobrands/northumberland/images/pin-orange.png b/web/i/pins/orange/pin.png similarity index 100% rename from web/cobrands/northumberland/images/pin-orange.png rename to web/i/pins/orange/pin.png diff --git a/web/cobrands/northumberland/images/pin-orange-small.png b/web/i/pins/orange/small.png similarity index 100% rename from web/cobrands/northumberland/images/pin-orange-small.png rename to web/i/pins/orange/small.png diff --git a/web/cobrands/northumberland/images/pin-red-big.png b/web/i/pins/red/big.png similarity index 100% rename from web/cobrands/northumberland/images/pin-red-big.png rename to web/i/pins/red/big.png diff --git a/web/cobrands/northumberland/images/pin-red-mini.png b/web/i/pins/red/mini.png similarity index 100% rename from web/cobrands/northumberland/images/pin-red-mini.png rename to web/i/pins/red/mini.png diff --git a/web/cobrands/northumberland/images/pin-red.png b/web/i/pins/red/pin.png similarity index 100% rename from web/cobrands/northumberland/images/pin-red.png rename to web/i/pins/red/pin.png diff --git a/web/cobrands/northumberland/images/pin-red-small.png b/web/i/pins/red/small.png similarity index 100% rename from web/cobrands/northumberland/images/pin-red-small.png rename to web/i/pins/red/small.png diff --git a/web/cobrands/northumberland/images/pin-shadow-big.png b/web/i/pins/shadow/big.png similarity index 100% rename from web/cobrands/northumberland/images/pin-shadow-big.png rename to web/i/pins/shadow/big.png diff --git a/web/cobrands/northumberland/images/pin-shadow.png b/web/i/pins/shadow/pin.png similarity index 100% rename from web/cobrands/northumberland/images/pin-shadow.png rename to web/i/pins/shadow/pin.png diff --git a/web/cobrands/northumberland/images/pin-shadow-small.png b/web/i/pins/shadow/small.png similarity index 100% rename from web/cobrands/northumberland/images/pin-shadow-small.png rename to web/i/pins/shadow/small.png diff --git a/web/cobrands/northumberland/images/pin-spot.png b/web/i/pins/spot.png similarity index 100% rename from web/cobrands/northumberland/images/pin-spot.png rename to web/i/pins/spot.png diff --git a/web/cobrands/oxfordshire/images/pin-shadow-big.png b/web/i/pins/whole-shadow-cone-spot/shadow/big.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-shadow-big.png rename to web/i/pins/whole-shadow-cone-spot/shadow/big.png diff --git a/web/cobrands/oxfordshire/images/pin-shadow.png b/web/i/pins/whole-shadow-cone-spot/shadow/pin.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-shadow.png rename to web/i/pins/whole-shadow-cone-spot/shadow/pin.png diff --git a/web/cobrands/oxfordshire/images/pin-shadow-small.png b/web/i/pins/whole-shadow-cone-spot/shadow/small.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-shadow-small.png rename to web/i/pins/whole-shadow-cone-spot/shadow/small.png diff --git a/web/cobrands/oxfordshire/images/pin-spot.png b/web/i/pins/whole-shadow-cone-spot/spot.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-spot.png rename to web/i/pins/whole-shadow-cone-spot/spot.png diff --git a/web/cobrands/oxfordshire/images/pin-yellow-big.png b/web/i/pins/yellow-cone/big.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-yellow-big.png rename to web/i/pins/yellow-cone/big.png diff --git a/web/cobrands/oxfordshire/images/pin-yellow-mini.png b/web/i/pins/yellow-cone/mini.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-yellow-mini.png rename to web/i/pins/yellow-cone/mini.png diff --git a/web/cobrands/oxfordshire/images/pin-yellow.png b/web/i/pins/yellow-cone/pin.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-yellow.png rename to web/i/pins/yellow-cone/pin.png diff --git a/web/cobrands/oxfordshire/images/pin-yellow-small.png b/web/i/pins/yellow-cone/small.png similarity index 100% rename from web/cobrands/oxfordshire/images/pin-yellow-small.png rename to web/i/pins/yellow-cone/small.png diff --git a/web/cobrands/northumberland/images/pin-yellow-big.png b/web/i/pins/yellow/big.png similarity index 100% rename from web/cobrands/northumberland/images/pin-yellow-big.png rename to web/i/pins/yellow/big.png diff --git a/web/cobrands/northumberland/images/pin-yellow-mini.png b/web/i/pins/yellow/mini.png similarity index 100% rename from web/cobrands/northumberland/images/pin-yellow-mini.png rename to web/i/pins/yellow/mini.png diff --git a/web/cobrands/northumberland/images/pin-yellow.png b/web/i/pins/yellow/pin.png similarity index 100% rename from web/cobrands/northumberland/images/pin-yellow.png rename to web/i/pins/yellow/pin.png diff --git a/web/cobrands/northumberland/images/pin-yellow-small.png b/web/i/pins/yellow/small.png similarity index 100% rename from web/cobrands/northumberland/images/pin-yellow-small.png rename to web/i/pins/yellow/small.png diff --git a/web/js/map-OpenLayers.js b/web/js/map-OpenLayers.js index be582f5d66..3e3352db94 100644 --- a/web/js/map-OpenLayers.js +++ b/web/js/map-OpenLayers.js @@ -800,12 +800,12 @@ $.extend(fixmystreet.utils, { }); pin_layer_style_map.addUniqueValueRules('default', 'size', { 'normal': { - externalGraphic: fixmystreet.pin_prefix + "pin-${colour}.png", + externalGraphic: "/i/pins/${colour}/pin.png", graphicWidth: 48, graphicHeight: 64, graphicXOffset: -24, graphicYOffset: -64, - backgroundGraphic: fixmystreet.pin_prefix + "pin-shadow.png", + backgroundGraphic: fixmystreet.pin_prefix + "shadow/pin.png", backgroundWidth: 60, backgroundHeight: 30, backgroundXOffset: -7, @@ -813,24 +813,24 @@ $.extend(fixmystreet.utils, { popupYOffset: -40 }, 'big': { - externalGraphic: fixmystreet.pin_prefix + "pin-${colour}-big.png", + externalGraphic: "/i/pins/${colour}/big.png", graphicWidth: 78, graphicHeight: 105, graphicXOffset: -39, graphicYOffset: -105, - backgroundGraphic: fixmystreet.pin_prefix + "pin-shadow-big.png", + backgroundGraphic: fixmystreet.pin_prefix + "shadow/big.png", backgroundWidth: 88, backgroundHeight: 40, backgroundXOffset: -10, backgroundYOffset: -35 }, 'small': { - externalGraphic: fixmystreet.pin_prefix + "pin-${colour}-small.png", + externalGraphic: "/i/pins/${colour}/small.png", graphicWidth: 24, graphicHeight: 32, graphicXOffset: -12, graphicYOffset: -32, - backgroundGraphic: fixmystreet.pin_prefix + "pin-shadow-small.png", + backgroundGraphic: fixmystreet.pin_prefix + "shadow/small.png", backgroundWidth: 30, backgroundHeight: 15, backgroundXOffset: -4, @@ -838,7 +838,7 @@ $.extend(fixmystreet.utils, { popupYOffset: -20 }, 'mini': { - externalGraphic: fixmystreet.pin_prefix + "pin-${colour}-mini.png", + externalGraphic: "/i/pins/${colour}/mini.png", graphicWidth: 16, graphicHeight: 20, graphicXOffset: -8,