Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N/land] Pass category updates to/from Alloy #5289

Open
wants to merge 2 commits into
base: nland-assigned-to-extra-details
Choose a base branch
from

Conversation

nephila-nacrea
Copy link
Contributor

@nephila-nacrea nephila-nacrea self-assigned this Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (702d107) to head (09ebd76).

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Northumberland.pm 0.00% 4 Missing and 1 partial ⚠️
perllib/Open311/UpdatesBase.pm 0.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           nland-assigned-to-extra-details    #5289      +/-   ##
===================================================================
- Coverage                            82.51%   82.49%   -0.03%     
===================================================================
  Files                                  406      406              
  Lines                                31732    31742      +10     
  Branches                              5049     5054       +5     
===================================================================
  Hits                                 26185    26185              
- Misses                                4056     4063       +7     
- Partials                              1491     1494       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nephila-nacrea nephila-nacrea requested a review from dracos December 5, 2024 12:03
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; perhaps a quick check that group is one of the $contact->group would make sense, though if they don't match, not sure what we would do, so perhaps doesn't really matter!

@nephila-nacrea
Copy link
Contributor Author

Looks good; perhaps a quick check that group is one of the $contact->group would make sense, though if they don't match, not sure what we would do, so perhaps doesn't really matter!

@dracos So I had actually faffed with this a bit, then realised it might not work or be hard to correct if, on the Alloy end, someone edited the category, forgot to change the group, but later edited the group. It would probably come in as two separate edits our end, but then one or neither would apply because of the group-must-match-category checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants