-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[N/land] Pass category updates to/from Alloy #5289
base: nland-assigned-to-extra-details
Are you sure you want to change the base?
[N/land] Pass category updates to/from Alloy #5289
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nland-assigned-to-extra-details #5289 +/- ##
===================================================================
- Coverage 82.51% 82.49% -0.03%
===================================================================
Files 406 406
Lines 31732 31742 +10
Branches 5049 5054 +5
===================================================================
Hits 26185 26185
- Misses 4056 4063 +7
- Partials 1491 1494 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; perhaps a quick check that group is one of the $contact->group would make sense, though if they don't match, not sure what we would do, so perhaps doesn't really matter!
@dracos So I had actually faffed with this a bit, then realised it might not work or be hard to correct if, on the Alloy end, someone edited the category, forgot to change the group, but later edited the group. It would probably come in as two separate edits our end, but then one or neither would apply because of the group-must-match-category checks. |
Fixes https://github.com/mysociety/societyworks/issues/4648.
[skip changelog]