Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merton] Adds parks and open spaces layer #5294

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MorayMySoc
Copy link
Contributor

@MorayMySoc MorayMySoc commented Dec 6, 2024

[Merton] Adds parks and open spaces layer

Layer contains parks that Merton not responsible for:
Wimbledon Common, Mitcham Common, Morden Hall Park
which have specific stoppers to guide to the right
place.

Only allowed to make a park report on a park or open
space on the layer for responsible parks.

Exceptional park Commons Extension Sports Ground is
in Kingston, but is responsibility of Merton so
can be selected from Merton Cobrand.

And Cypress tests

https://github.com/mysociety/societyworks/issues/4643
https://mysocietysupport.freshdesk.com/a/tickets/3934

Server config in same branch on servers

[skip changelog]

Layer contains parks that Merton not responsible for:
Wimbledon Common, Mitcham Common, Morden Hall Park
which have specific stoppers to guide to the right
place.

Only allowed to make a park report on a park or open
space on the layer for responsible parks.

Exceptional park Commons Extension Sports Ground is
in Kingston, but is responsibility of Merton so
can be selected from Merton Cobrand.

mysociety/societyworks#4643
https://mysocietysupport.freshdesk.com/a/tickets/3934
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.31%. Comparing base (287f7d2) to head (5e0bea5).

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Merton.pm 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5294      +/-   ##
==========================================
- Coverage   82.34%   82.31%   -0.04%     
==========================================
  Files         413      413              
  Lines       32719    32744      +25     
  Branches     5241     5242       +1     
==========================================
+ Hits        26942    26952      +10     
- Misses       4225     4240      +15     
  Partials     1552     1552              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MorayMySoc MorayMySoc requested a review from dracos December 6, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant