Prevent Open311 updates from being sent out of order #5298
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5298 +/- ##
==========================================
+ Coverage 82.40% 82.42% +0.02%
==========================================
Files 415 415
Lines 32855 32864 +9
Branches 5270 5271 +1
==========================================
+ Hits 27074 27088 +14
+ Misses 4223 4218 -5
Partials 1558 1558 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks good, so just one more small further step - you can get rid of the order_by (as you don't care any more), I'd add an id => { "!=" => $comment->id } to be on the safe side (not sure if there might be some rounding issues with the date formatting), add { rows => 1 } as a second parameter to search() (because you only care about getting one result) and then add ->single after the search, putting the result in a scalar, not an array (so you get that one result or undef). :)
nephila-nacrea
force-pushed
the
FD4750-prevent-out-of-order-updates
branch
from
c10627f to
97579a7
Compare
nephila-nacrea
temporarily deployed
to
github-pages
Updates are selected in random order but some cobrands/APIs (e.g. Northumberland/Alloy) do not know how to handle updates in order their end, so an earlier update may overwrite a later one.
This change checks that an update is not sent until earlier updates for that problem are sent.
Fixes https://github.com/mysociety/societyworks/issues/4640.
[skip changelog]