Pin tidying, plus Bromley #5299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5299 +/- ##
==========================================
+ Coverage 82.40% 82.42% +0.01%
==========================================
Files 415 415
Lines 32833 32836 +3
Branches 5265 5267 +2
==========================================
+ Hits 27055 27064 +9
+ Misses 4222 4216 -6
Partials 1556 1556 ☔ View full report in Codecov by Sentry. |
MorayMySoc
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
I think I like this - don't know if it's worth running past anyone else - I like not having one Cobrand's directory for multiple Cobrands. And also not thinking about the shadows when you're doing it which is minor, but easy to overlook. Could path_to_pin_icons be in UKCouncils? Sorry, this was a lot of stuff for a relatively small issue. I think it's an improvement though...
dracos
force-pushed
the
pin-tidying-plus-bromley
branch
from
3e3dea9 to
94bfd69
Compare
This puts them all under web/i/pins, one directory per 'colour', path_to_pin_icons is only used for sourcing shadow/spot files.
dracos
force-pushed
the
pin-tidying-plus-bromley
branch
from
94bfd69 to
7eb2407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip changelog]
As discussed, might fix https://github.com/mysociety/societyworks/issues/4653 and for FD-4899