From 3b84fad6029103413434980e20f68fce98bca543 Mon Sep 17 00:00:00 2001
From: Alexibu <alex@sunopti.com>
Date: Fri, 22 Dec 2023 19:50:32 +1100
Subject: [PATCH 01/13] Mod to  consume all bytes from a timestamp with sub
 second resolution.

---
 source/mysql/protocol/packet_helpers.d | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/source/mysql/protocol/packet_helpers.d b/source/mysql/protocol/packet_helpers.d
index 35f3979a..04d69cce 100644
--- a/source/mysql/protocol/packet_helpers.d
+++ b/source/mysql/protocol/packet_helpers.d
@@ -461,6 +461,8 @@ do
 		hour    = packet.consume!ubyte();
 		minute  = packet.consume!ubyte();
 		second  = packet.consume!ubyte();
+		foreach(i;7..numBytes)
+			packet.consume!ubyte();
 	}
 	return DateTime(year, month, day, hour, minute, second);
 }

From 44224a58b437d79068d6c80dadcdef442ff3f3a6 Mon Sep 17 00:00:00 2001
From: Alex Burton <alex@sunopti.com>
Date: Thu, 28 Dec 2023 07:58:41 +0000
Subject: [PATCH 02/13] Support datetime with msecs

---
 source/mysql/protocol/packet_helpers.d | 54 +++++++++++++++++---------
 source/mysql/types.d                   | 18 +++++++--
 2 files changed, 50 insertions(+), 22 deletions(-)

diff --git a/source/mysql/protocol/packet_helpers.d b/source/mysql/protocol/packet_helpers.d
index 04d69cce..6fc7c8d7 100644
--- a/source/mysql/protocol/packet_helpers.d
+++ b/source/mysql/protocol/packet_helpers.d
@@ -218,7 +218,7 @@ ubyte[] pack(in Date dt) pure nothrow
 }
 
 /++
-Function to extract a DateTime from a binary encoded row.
+Function to extract a DateTimeExt from a binary encoded row.
 
 Time/date structures are packed by the server into a byte sub-packet
 with a leading length byte, and a minimal number of bytes to embody the data.
@@ -227,20 +227,20 @@ Params: a = slice of a protocol packet beginning at the length byte for a
             chunk of DateTime data
 Returns: A populated or default initialized `std.datetime.DateTime` struct.
 +/
-DateTime toDateTime(in ubyte[] a) pure
+DateTimeExt toDateTime(in ubyte[] a) pure
 {
 	enforce!MYXProtocol(a.length, "Supplied byte array is zero length");
 	if (a[0] == 0)
-		return DateTime();
+		return DateTimeExt(DateTimeExt(),0);
 
 	enforce!MYXProtocol(a[0] >= 4, "Supplied ubyte[] is not long enough");
 	int year    = (a[2] << 8) + a[1];
 	int month   =  a[3];
 	int day     =  a[4];
-	DateTime dt;
+	DateTimeExt dt;
 	if (a[0] == 4)
 	{
-		dt = DateTime(year, month, day);
+		dt = DateTimeExt(DateTime(year, month, day),0);
 	}
 	else
 	{
@@ -248,7 +248,10 @@ DateTime toDateTime(in ubyte[] a) pure
 		int hour    = a[5];
 		int minute  = a[6];
 		int second  = a[7];
-		dt = DateTime(year, month, day, hour, minute, second);
+		int millisecond = 0;
+		if (a[0] >= 11)
+			millisecond = (a[11] << 24) + (a[10] << 16) + (a[9] << 8) + a[8];
+		dt = DateTimeExt(DateTime(year, month, day, hour, minute, second),millisecond);
 	}
 	return dt;
 }
@@ -261,7 +264,7 @@ Text representations of a DateTime are as in 2011-11-11 12:20:02
 Params: s = A string representation of the time difference.
 Returns: A populated or default initialized `std.datetime.DateTime` struct.
 +/
-DateTime toDateTime(const(char)[] s)
+DateTimeExt toDateTime(const(char)[] s)
 {
 	int year = parse!(ushort)(s);
 	enforce!MYXProtocol(s.skipOver("-"), `Expected: "-"`);
@@ -274,18 +277,18 @@ DateTime toDateTime(const(char)[] s)
 	int minute = parse!(ubyte)(s);
 	enforce!MYXProtocol(s.skipOver(":"), `Expected: ":"`);
 	int second = parse!(ubyte)(s);
-	return DateTime(year, month, day, hour, minute, second);
+	return DateTimeExt(DateTime(year, month, day, hour, minute, second),0);
 }
 
 /++
-Function to extract a DateTime from a ulong.
+Function to extract a DateTimeExt from a ulong.
 
 This is used to support the TimeStamp  struct.
 
 Params: x = A ulong e.g. 20111111122002UL.
 Returns: A populated `std.datetime.DateTime` struct.
 +/
-DateTime toDateTime(ulong x)
+DateTimeExt toDateTime(ulong x)
 {
 	int second = cast(int) (x%100);
 	x /= 100;
@@ -302,7 +305,7 @@ DateTime toDateTime(ulong x)
 	enforce!MYXProtocol(year >= 1970 &&  year < 2039, "Date/time out of range for 2 bit timestamp");
 	enforce!MYXProtocol(year != 2038 || (month < 1 && day < 19 && hour < 3 && minute < 14 && second < 7),
 			"Date/time out of range for 2 bit timestamp");
-	return DateTime(year, month, day, hour, minute, second);
+	return DateTimeExt(DateTime(year, month, day, hour, minute, second),0);
 }
 
 /++
@@ -314,11 +317,12 @@ and a minimal number of bytes to embody the data.
 Params: dt = `std.datetime.DateTime` struct.
 Returns: Packed ubyte[].
 +/
-ubyte[] pack(in DateTime dt) pure nothrow
+ubyte[] pack(in DateTimeExt dt) pure nothrow
 {
 	uint len = 1;
 	if (dt.year || dt.month || dt.day) len = 5;
 	if (dt.hour || dt.minute|| dt.second) len = 8;
+	if (dt.msecs) len = 12;
 	ubyte[] rv;
 	rv.length = len;
 	rv[0] =  cast(ubyte)(rv.length - 1); // num bytes
@@ -335,6 +339,13 @@ ubyte[] pack(in DateTime dt) pure nothrow
 		rv[6] = cast(ubyte) dt.minute;
 		rv[7] = cast(ubyte) dt.second;
 	}
+	if (len == 12)
+	{
+		rv[8] = cast(ubyte)dt.msecs;
+		rv[9] = cast(ubyte)(dt.msecs >> 8);
+		rv[10] = cast(ubyte)(dt.msecs >> 16);
+		rv[11] = cast(ubyte)(dt.msecs >> 24);
+	}
 	return rv;
 }
 
@@ -435,7 +446,7 @@ do
 	return toDate(packet.consume(5));
 }
 
-DateTime consume(T:DateTime, ubyte N=T.sizeof)(ref ubyte[] packet) pure
+DateTimeExt consume(T:DateTimeExt, ubyte N=T.sizeof)(ref ubyte[] packet) pure
 in
 {
 	assert(packet.length);
@@ -445,7 +456,7 @@ do
 {
 	auto numBytes = packet.consume!ubyte();
 	if(numBytes == 0)
-		return DateTime();
+		return DateTimeExt(DateTime(),0);
 
 	enforce!MYXProtocol(numBytes >= 4, "Supplied packet is not large enough to store DateTime");
 
@@ -455,16 +466,19 @@ do
 	int hour    = 0;
 	int minute  = 0;
 	int second  = 0;
+	int msecs = 0;
 	if(numBytes > 4)
 	{
 		enforce!MYXProtocol(numBytes >= 7, "Supplied packet is not large enough to store a DateTime with TimeOfDay");
 		hour    = packet.consume!ubyte();
 		minute  = packet.consume!ubyte();
 		second  = packet.consume!ubyte();
-		foreach(i;7..numBytes)
-			packet.consume!ubyte();
 	}
-	return DateTime(year, month, day, hour, minute, second);
+	if (numBytes >= 11)
+	{
+		msecs = packet.consume!uint;
+	}
+	return DateTimeExt(DateTime(year, month, day, hour, minute, second),msecs);
 }
 
 
@@ -537,6 +551,8 @@ do
 T myto(T)(const(char)[] value)
 {
 	static if(is(T == DateTime))
+		return toDateTime(value).dt;
+	else static if(is(T == DateTimeExt))
 		return toDateTime(value);
 	else static if(is(T == Date))
 		return toDate(value);
@@ -671,7 +687,7 @@ SQLValue consumeIfComplete()(ref ubyte[] packet, SQLType sqlType, bool binary, b
 		case SQLType.DOUBLE:
 			return packet.consumeIfComplete!double(binary, unsigned);
 		case SQLType.TIMESTAMP:
-			return packet.consumeIfComplete!DateTime(binary, unsigned);
+			return packet.consumeIfComplete!DateTimeExt(binary, unsigned);
 		case SQLType.TIME:
 			return packet.consumeIfComplete!TimeOfDay(binary, unsigned);
 		case SQLType.YEAR:
@@ -679,7 +695,7 @@ SQLValue consumeIfComplete()(ref ubyte[] packet, SQLType sqlType, bool binary, b
 		case SQLType.DATE:
 			return packet.consumeIfComplete!Date(binary, unsigned);
 		case SQLType.DATETIME:
-			return packet.consumeIfComplete!DateTime(binary, unsigned);
+			return packet.consumeIfComplete!DateTimeExt(binary, unsigned);
 		case SQLType.VARCHAR:
 		case SQLType.ENUM:
 		case SQLType.SET:
diff --git a/source/mysql/types.d b/source/mysql/types.d
index 53932e86..c4208fce 100644
--- a/source/mysql/types.d
+++ b/source/mysql/types.d
@@ -33,6 +33,18 @@ struct Timestamp
 	ulong rep;
 }
 
+/++
+A D struct to stand for a DateTime with sub second resolution
+
++/
+struct DateTimeExt
+{
+	DateTime dt;
+	alias dt this;
+	uint msecs;
+}
+
+
 private union _MYTYPE
 {
 @safeOnly:
@@ -54,7 +66,7 @@ private union _MYTYPE
 	long Long;
 	float Float;
 	double Double;
-	.DateTime DateTime;
+	DateTimeExt DateTime;
 	TimeOfDay Time;
 	.Timestamp Timestamp;
 	.Date Date;
@@ -74,7 +86,7 @@ private union _MYTYPE
 	const(long)* LongRef;
 	const(float)* FloatRef;
 	const(double)* DoubleRef;
-	const(.DateTime)* DateTimeRef;
+	const(DateTimeExt)* DateTimeRef;
 	const(TimeOfDay)* TimeRef;
 	const(.Date)* DateRef;
 	const(string)* TextRef;
@@ -209,7 +221,7 @@ package MySQLVal _toVal(Variant v)
 			enum FQN = T.stringof;
 	}
 
-	alias BasicTypes = AliasSeq!(bool, byte, ubyte, short, ushort, int, uint, long, ulong, float, double, DateTime, TimeOfDay, Date, Timestamp);
+	alias BasicTypes = AliasSeq!(bool, byte, ubyte, short, ushort, int, uint, long, ulong, float, double, DateTimeExt, TimeOfDay, Date, Timestamp);
 	alias ArrayTypes = AliasSeq!(char[], const(char)[],
 								 ubyte[], const(ubyte)[], immutable(ubyte)[]);
 

From a73e4141251b3c1089ad3d37421529f332612497 Mon Sep 17 00:00:00 2001
From: Alex Burton <alex@sunopti.com>
Date: Thu, 28 Dec 2023 09:56:33 +0000
Subject: [PATCH 03/13] add toString to DateTimeEx

---
 source/mysql/types.d | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/source/mysql/types.d b/source/mysql/types.d
index c4208fce..004b7600 100644
--- a/source/mysql/types.d
+++ b/source/mysql/types.d
@@ -42,6 +42,10 @@ struct DateTimeExt
 	DateTime dt;
 	alias dt this;
 	uint msecs;
+	string toString() pure nothrow @safe const
+	{
+		return dt.toString ~ "." ~ to!string(msecs);
+	}
 }
 
 

From e2d2fb00fa7084a3c22502c3bfc476bed4fdb81d Mon Sep 17 00:00:00 2001
From: Alex Burton <alex@sunopti.com>
Date: Thu, 28 Dec 2023 10:00:33 +0000
Subject: [PATCH 04/13] need conv

---
 source/mysql/types.d | 1 +
 1 file changed, 1 insertion(+)

diff --git a/source/mysql/types.d b/source/mysql/types.d
index 004b7600..36d752b5 100644
--- a/source/mysql/types.d
+++ b/source/mysql/types.d
@@ -3,6 +3,7 @@ module mysql.types;
 import taggedalgebraic.taggedalgebraic;
 import std.datetime : DateTime, TimeOfDay, Date;
 import std.typecons : Nullable;
+import std.conv;
 
 /++
 A simple struct to represent time difference.

From 2218a7990993df12342d1a63dc26ea10fd5a3662 Mon Sep 17 00:00:00 2001
From: Alex Burton <alex@sunopti.com>
Date: Thu, 28 Dec 2023 10:38:05 +0000
Subject: [PATCH 05/13] the value is actually usecs

---
 source/mysql/types.d | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/source/mysql/types.d b/source/mysql/types.d
index 36d752b5..a28ee734 100644
--- a/source/mysql/types.d
+++ b/source/mysql/types.d
@@ -1,9 +1,9 @@
 /// Structures for MySQL types not built-in to D/Phobos.
 module mysql.types;
 import taggedalgebraic.taggedalgebraic;
-import std.datetime : DateTime, TimeOfDay, Date;
+import std.datetime : DateTime, TimeOfDay, Date, SysTime;
 import std.typecons : Nullable;
-import std.conv;
+import std.format;
 
 /++
 A simple struct to represent time difference.
@@ -42,10 +42,15 @@ struct DateTimeExt
 {
 	DateTime dt;
 	alias dt this;
-	uint msecs;
+	uint usecs;
 	string toString() pure nothrow @safe const
 	{
-		return dt.toString ~ "." ~ to!string(msecs);
+		return dt.toString ~ format(".%06d",this.usecs);
+	}
+	SysTime opCast(T)() @safe const pure nothrow scope
+		if (is(immutable T == immutable SysTime))
+	{
+		return SysTime(dt) + .usecs(this.usecs);
 	}
 }
 

From e68657d31317d58b60a4be6e75edbbb4a054f179 Mon Sep 17 00:00:00 2001
From: Alex Burton <alex@sunopti.com>
Date: Thu, 28 Dec 2023 11:29:36 +0000
Subject: [PATCH 06/13] change usecs to different name

---
 source/mysql/types.d | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/source/mysql/types.d b/source/mysql/types.d
index a28ee734..93dca581 100644
--- a/source/mysql/types.d
+++ b/source/mysql/types.d
@@ -42,15 +42,14 @@ struct DateTimeExt
 {
 	DateTime dt;
 	alias dt this;
-	uint usecs;
+	uint u_seconds;
 	string toString() pure nothrow @safe const
 	{
-		return dt.toString ~ format(".%06d",this.usecs);
+		return dt.toString ~ format(".%06d",this.u_seconds);
 	}
-	SysTime opCast(T)() @safe const pure nothrow scope
-		if (is(immutable T == immutable SysTime))
+	SysTime makeSysTime(return scope immutable TimeZone tz = null) @safe const pure nothrow scope
 	{
-		return SysTime(dt) + .usecs(this.usecs);
+		return SysTime(dt,usecs(this.u_seconds),tz);
 	}
 }
 

From 1f2021fbb4a1830698f2215ca19b43b2e39fde90 Mon Sep 17 00:00:00 2001
From: Alex Burton <alex@sunopti.com>
Date: Thu, 28 Dec 2023 11:32:24 +0000
Subject: [PATCH 07/13] import timezone

---
 source/mysql/types.d | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source/mysql/types.d b/source/mysql/types.d
index 93dca581..6379b4b6 100644
--- a/source/mysql/types.d
+++ b/source/mysql/types.d
@@ -1,7 +1,7 @@
 /// Structures for MySQL types not built-in to D/Phobos.
 module mysql.types;
 import taggedalgebraic.taggedalgebraic;
-import std.datetime : DateTime, TimeOfDay, Date, SysTime;
+import std.datetime : DateTime, TimeOfDay, Date, SysTime,TimeZone;
 import std.typecons : Nullable;
 import std.format;
 

From a0df3cf6b08c6fc690eca93d0d49b54347052146 Mon Sep 17 00:00:00 2001
From: Alex Burton <alex@sunopti.com>
Date: Thu, 28 Dec 2023 11:34:56 +0000
Subject: [PATCH 08/13] more fixes

---
 source/mysql/protocol/packet_helpers.d | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/source/mysql/protocol/packet_helpers.d b/source/mysql/protocol/packet_helpers.d
index 6fc7c8d7..6ef5479e 100644
--- a/source/mysql/protocol/packet_helpers.d
+++ b/source/mysql/protocol/packet_helpers.d
@@ -322,7 +322,7 @@ ubyte[] pack(in DateTimeExt dt) pure nothrow
 	uint len = 1;
 	if (dt.year || dt.month || dt.day) len = 5;
 	if (dt.hour || dt.minute|| dt.second) len = 8;
-	if (dt.msecs) len = 12;
+	if (dt.u_seconds) len = 12;
 	ubyte[] rv;
 	rv.length = len;
 	rv[0] =  cast(ubyte)(rv.length - 1); // num bytes
@@ -341,10 +341,10 @@ ubyte[] pack(in DateTimeExt dt) pure nothrow
 	}
 	if (len == 12)
 	{
-		rv[8] = cast(ubyte)dt.msecs;
-		rv[9] = cast(ubyte)(dt.msecs >> 8);
-		rv[10] = cast(ubyte)(dt.msecs >> 16);
-		rv[11] = cast(ubyte)(dt.msecs >> 24);
+		rv[8] = cast(ubyte)dt.u_seconds;
+		rv[9] = cast(ubyte)(dt.u_seconds >> 8);
+		rv[10] = cast(ubyte)(dt.u_seconds >> 16);
+		rv[11] = cast(ubyte)(dt.u_seconds >> 24);
 	}
 	return rv;
 }
@@ -466,7 +466,7 @@ do
 	int hour    = 0;
 	int minute  = 0;
 	int second  = 0;
-	int msecs = 0;
+	int u_seconds = 0;
 	if(numBytes > 4)
 	{
 		enforce!MYXProtocol(numBytes >= 7, "Supplied packet is not large enough to store a DateTime with TimeOfDay");
@@ -476,9 +476,9 @@ do
 	}
 	if (numBytes >= 11)
 	{
-		msecs = packet.consume!uint;
+		u_seconds = packet.consume!uint;
 	}
-	return DateTimeExt(DateTime(year, month, day, hour, minute, second),msecs);
+	return DateTimeExt(DateTime(year, month, day, hour, minute, second),u_seconds);
 }
 
 

From c0e59b740db3e9fda685f1198b0466db1eec260e Mon Sep 17 00:00:00 2001
From: Alex Burton <alex@sunopti.com>
Date: Thu, 28 Dec 2023 11:42:54 +0000
Subject: [PATCH 09/13] nothrow toString

---
 source/mysql/types.d | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/source/mysql/types.d b/source/mysql/types.d
index 6379b4b6..1924aac2 100644
--- a/source/mysql/types.d
+++ b/source/mysql/types.d
@@ -1,7 +1,7 @@
 /// Structures for MySQL types not built-in to D/Phobos.
 module mysql.types;
 import taggedalgebraic.taggedalgebraic;
-import std.datetime : DateTime, TimeOfDay, Date, SysTime,TimeZone;
+import std.datetime : DateTime, TimeOfDay, Date, SysTime,TimeZone,usecs;
 import std.typecons : Nullable;
 import std.format;
 
@@ -45,9 +45,12 @@ struct DateTimeExt
 	uint u_seconds;
 	string toString() pure nothrow @safe const
 	{
-		return dt.toString ~ format(".%06d",this.u_seconds);
+		try
+			return dt.toString ~ format(".%06d",this.u_seconds);
+		catch(Exception e)
+			assert(0,"DateTimeExt.toString threw");
 	}
-	SysTime makeSysTime(return scope immutable TimeZone tz = null) @safe const pure nothrow scope
+	SysTime makeSysTime(return scope immutable TimeZone tz = null) @safe const scope
 	{
 		return SysTime(dt,usecs(this.u_seconds),tz);
 	}

From 65540a7df4738c48bf9d72f2bac88abe0c606da3 Mon Sep 17 00:00:00 2001
From: Alex Burton <alex@sunopti.com>
Date: Thu, 28 Dec 2023 11:50:56 +0000
Subject: [PATCH 10/13] change datetime toSTring format

---
 source/mysql/types.d | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source/mysql/types.d b/source/mysql/types.d
index 1924aac2..408e2b3d 100644
--- a/source/mysql/types.d
+++ b/source/mysql/types.d
@@ -46,7 +46,7 @@ struct DateTimeExt
 	string toString() pure nothrow @safe const
 	{
 		try
-			return dt.toString ~ format(".%06d",this.u_seconds);
+			return dt.date.toISOExtString ~ " " ~ dt.timeOfDay.toISOExtString ~ format(".%06d",this.u_seconds);
 		catch(Exception e)
 			assert(0,"DateTimeExt.toString threw");
 	}

From baa5fee4717826952e5a51e6cb6ba8e4d5309515 Mon Sep 17 00:00:00 2001
From: Alex Burton <alex@sunopti.com>
Date: Thu, 28 Dec 2023 12:27:39 +0000
Subject: [PATCH 11/13] bug in pack

---
 source/mysql/protocol/packet_helpers.d | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/source/mysql/protocol/packet_helpers.d b/source/mysql/protocol/packet_helpers.d
index 6ef5479e..ff930139 100644
--- a/source/mysql/protocol/packet_helpers.d
+++ b/source/mysql/protocol/packet_helpers.d
@@ -333,18 +333,18 @@ ubyte[] pack(in DateTimeExt dt) pure nothrow
 		rv[3] = cast(ubyte)   dt.month;
 		rv[4] = cast(ubyte)   dt.day;
 	}
-	if(len == 8)
+	if(len >= 8)
 	{
 		rv[5] = cast(ubyte) dt.hour;
 		rv[6] = cast(ubyte) dt.minute;
 		rv[7] = cast(ubyte) dt.second;
 	}
-	if (len == 12)
+	if (len >= 12)
 	{
-		rv[8] = cast(ubyte)dt.u_seconds;
-		rv[9] = cast(ubyte)(dt.u_seconds >> 8);
-		rv[10] = cast(ubyte)(dt.u_seconds >> 16);
-		rv[11] = cast(ubyte)(dt.u_seconds >> 24);
+		rv[8] = cast(ubyte)(dt.u_seconds & 0x0ff);
+		rv[9] = cast(ubyte)((dt.u_seconds >> 8) & 0x0ff);
+		rv[10] = cast(ubyte)((dt.u_seconds >> 16) & 0x0ff);
+		rv[11] = cast(ubyte)((dt.u_seconds >> 24) & 0x0ff);
 	}
 	return rv;
 }

From cc16abeb22da44ef624d6169feb7ca97f15728c8 Mon Sep 17 00:00:00 2001
From: Alexibu <alex@sunopti.com>
Date: Fri, 29 Dec 2023 01:43:14 +0000
Subject: [PATCH 12/13] handle incomplete packets

---
 source/mysql/protocol/packet_helpers.d | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/mysql/protocol/packet_helpers.d b/source/mysql/protocol/packet_helpers.d
index ff930139..65e2fe05 100644
--- a/source/mysql/protocol/packet_helpers.d
+++ b/source/mysql/protocol/packet_helpers.d
@@ -593,8 +593,8 @@ SQLValue consumeBinaryValueIfComplete(T, int N=T.sizeof)(ref ubyte[] packet, boo
 {
 	SQLValue result;
 
-	// Length of DateTime packet is NOT DateTime.sizeof, it can be 1, 5 or 8 bytes
-	static if(is(T==DateTime))
+	// Length of DateTime packet is NOT DateTime.sizeof, it can be 1, 5 or 8 or 12 bytes
+	static if(is(T==DateTimeExt))
 		result.isIncomplete = packet.length < 1;
 	else
 		result.isIncomplete = packet.length < N;

From 169946a40b1671a37d6038b1e5f405bbcda8e494 Mon Sep 17 00:00:00 2001
From: Alexibu <alex@sunopti.com>
Date: Wed, 10 Jan 2024 00:06:50 +0000
Subject: [PATCH 13/13] fixed compilation failures in integration tests

---
 source/mysql/impl/prepared.d | 11 ++++++++++-
 source/mysql/types.d         | 11 +++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/source/mysql/impl/prepared.d b/source/mysql/impl/prepared.d
index fe099231..26f9df9b 100644
--- a/source/mysql/impl/prepared.d
+++ b/source/mysql/impl/prepared.d
@@ -24,6 +24,7 @@ import mysql.protocol.packets;
 import mysql.types;
 import mysql.impl.result;
 import mysql.safe.commands : ColumnSpecialization, CSN;
+import std.datetime : DateTime;
 
 /++
 A struct to represent specializations of prepared statement parameters.
@@ -153,11 +154,19 @@ public:
 
 		enforce!MYX(index < _numParams, "Parameter index out of range.");
 
-		_inParams[index] = val;
+		static if ((is (T == DateTime)) || (is (T == const(DateTime)))|| (is (T == immutable(DateTime))))
+		{
+			_inParams[index] = DateTimeExt(val,0);
+		}
+		else
+		{
+			_inParams[index] = val;
+		}
 		psn.pIndex = index;
 		_psa[index] = psn;
 	}
 
+	
 	///ditto
 	void setArg(T)(size_t index, Nullable!T val, SafeParameterSpecialization psn = SPSN.init)
 	{
diff --git a/source/mysql/types.d b/source/mysql/types.d
index 408e2b3d..9103b29f 100644
--- a/source/mysql/types.d
+++ b/source/mysql/types.d
@@ -54,6 +54,17 @@ struct DateTimeExt
 	{
 		return SysTime(dt,usecs(this.u_seconds),tz);
 	}
+	DateTimeExt opAssign(const DateTime x) @safe
+	{
+		dt = x;
+		u_seconds  = 0;
+		return this;
+	}
+	DateTime opCast(T)()
+	if (is(T == DateTime))
+	{
+		return dt;
+	}
 }