Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] 432Hz Batch Converter - export option to additionally apply r128gain/ReplayGain/WaveGain #31

Open
NintendoManiac64 opened this issue Jan 9, 2024 · 0 comments

Comments

@NintendoManiac64
Copy link

NintendoManiac64 commented Jan 9, 2024

Currently any r128gain/ReplayGain/WaveGain needs to be applied separately before or after conversion. Ideally the more modern r128gain algorithm should be used, but even the older original "Replay Gain" algorithm is better than nothing.

Since the dynamic range of some more classical songs can have an average perceived volume that is lower than the default 89dB even when the waveform is peak-normalized, it'd be best if it were a configurable setting what dB should be targeted.

Regardless, I envision three sort of modes:

  • apply directly to the waveform (WaveGain)
  • apply only metadata (r128gain/ReplayGain)
  • peak-normalize the waveform and only apply metadata

The last one is designed to maximize your bit depth resolution, particularly if you're limited to 16bit for whatever reason.

For the most accurate volume adjustments, any r128gain/ReplayGain/WaveGain should be applied at the very end of the processing chain, that being the step immediately before the audio is actually encoded into your selected output format (e.g. MP3, AAC, FLAC, WAV, etc) but before any bit depth down-conversion since any gain adjustment would ideally be processed at 32bit floating point precision even if the final output is 24bit or 16bit.

Speaking of WAV, the metadata function might not work specifically when exporting WAV files unless issue #29 were first resolved.

EDIT: Just re-discovered that this would also alleviate the quirk caused by resampling where 432Hz Batch Converter can end up clipping the resulting waveform a bit, though that itself could be possibly considered a stand-alone bug; see also: issue #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant