refactor!: use hex for debugging and display #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything except the ticket in the examples is now using hex Ref n0-computer/iroh#2841
dignifiedquire
changed the title
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-gossip/pr/2/docs/iroh_gossip/ Last updated: 2024-11-29T15:21:13Z |
rklaehn
reviewed
Oct 29, 2024
rklaehn
approved these changes
Nov 15, 2024
| #[derive(Eq, PartialEq)] | ||
| struct Id([u8; 32]); | ||
| idbytes_impls!(Id, "Id"); | ||
| let id: Id = [1u8; 32].into(); | ||
| assert_eq!(id, Id::from_str(&format!("{id}")).unwrap()); | ||
| assert_eq!( | ||
| &format!("{id}"), | ||
| "aeaqcaibaeaqcaibaeaqcaibaeaqcaibaeaqcaibaeaqcaibaeaq" | ||
| "0101010101010101010101010101010101010101010101010101010101010101" |
rklaehn
force-pushed
the
refactor-switch-to-hex
branch
from
baa3b7c to
da1cf6d
Compare
# Conflicts: # Cargo.toml # examples/chat.rs
rklaehn
force-pushed
the
refactor-switch-to-hex
branch
from
9dcff34 to
7bda326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything except the ticket in the examples is now using hex
Breaking Changes
Ids are now encoded and parsed as hex instead of base32Ref n0-computer/iroh#2841