From cc2d65c7416ac6443a9402ffdd9e845ae4ac54e5 Mon Sep 17 00:00:00 2001 From: Yuya Ochiai Date: Wed, 13 Apr 2016 23:34:50 +0900 Subject: [PATCH] Fix `npm run build` when using webpack 1.12.15 'remote' module is used in electron-connect but it's removed from electron target on webpack 1.12.15. So define 'remote' as "externals" to avoid bundling error. http://webpack.github.io/docs/configuration.html#externals --- gulpfile.js | 7 +++++-- package.json | 3 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/gulpfile.js b/gulpfile.js index a8a50002837..61ed0d276c9 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -107,7 +107,7 @@ gulp.task('webpack:browser', function() { __filename: false, __dirname: false }, - target: 'electron' + target: 'electron-renderer' })) .pipe(gulp.dest('dist/browser/')); }); @@ -128,7 +128,10 @@ gulp.task('webpack:main', function() { __filename: false, __dirname: false }, - target: 'electron' + target: 'electron-main', + externals: { + remote: true // for electron-connect + } })) .pipe(gulp.dest('dist/')); }); diff --git a/package.json b/package.json index 3492d439dc6..c5d5b07b775 100644 --- a/package.json +++ b/package.json @@ -30,7 +30,7 @@ "babel-preset-react": "^6.3.13", "chromedriver": "^2.20.0", "del": "^2.2.0", - "electron-connect": "^0.3.3", + "electron-connect": "^0.3.7", "electron-packager": "^5.1.0", "electron-prebuilt": "0.36.11", "esformatter": "^0.8.1", @@ -48,6 +48,7 @@ "through2": "^2.0.1", "vinyl-named": "^1.1.0", "webdriverio": "^3.3.0", + "webpack": "^1.12.15", "webpack-stream": "^3.1.0" } }