You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When using shimmers, at some point you'd want to replace them with the actual content. Right now, that requires DOM manipulation to replace the shimmer elements with the actual content.
Describe the solution you'd like
What if it shimmers were done using the :empty CSS pseudo selector, so that shimmer is displayed when there is no content (eg. <div></div>). When the content is retrieved and set, the shimmer would be replaced with the content. Such approach would remove the need to manipulate the DOM.
Describe alternatives you've considered
n/a
The text was updated successfully, but these errors were encountered:
Sounds good to me. Did some quick testing in DevTools and just changing the selectors to be .class:empty instead seems to just work.
With that said, you cannot get away from DOM manipulation if you want your loading indicator to accessible, as you would need to maintain the aria-busy attribute. See MDN
Is your feature request related to a problem? Please describe.
When using shimmers, at some point you'd want to replace them with the actual content. Right now, that requires DOM manipulation to replace the shimmer elements with the actual content.
Describe the solution you'd like
What if it shimmers were done using the
:empty
CSS pseudo selector, so that shimmer is displayed when there is no content (eg.<div></div>
). When the content is retrieved and set, the shimmer would be replaced with the content. Such approach would remove the need to manipulate the DOM.Describe alternatives you've considered
n/a
The text was updated successfully, but these errors were encountered: