Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow Node titles for LangChain nodes #4

Merged
merged 2 commits into from
Jan 4, 2024
Merged

fix: Allow Node titles for LangChain nodes #4

merged 2 commits into from
Jan 4, 2024

Conversation

OlegIvaniv
Copy link

Include Langchain nodes path when retrieving nodes display names

ivov
ivov requested changes Jan 3, 2024
View reviewed changes
src/parser.ts
Comment on lines +13 to +14
glob(path.resolve(LANGCHAIN_NODES_DIR, "**", "*.node.ts")),
glob(path.resolve(LANGCHAIN_NODES_DIR, "**", "versionDescription.ts")),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're destructuring the first two arrays from Promise.all() for the first two glob calls, so I'd expect these additions will be ignored?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad; I originally just commented out the first two items and kept the LC ones for testing and didn't realize that it's being deconstructed. Fixed & thanks for catching it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Thank you for your contribution!

PR titles in this repo follow our version of the Conventional Commits spec.
This allows us to automatically generate the changelog for the next release.
Therefore, we ask you to adjust your PR title to solve the issue(s) below:

@OlegIvaniv OlegIvaniv requested a review from ivov January 3, 2024 12:00
@OlegIvaniv OlegIvaniv merged commit 025e7b5 into master Jan 4, 2024
2 checks passed
@netroy
Copy link
Member

netroy commented Jan 12, 2024 •
edited
Loading

still seems to be failing https://github.com/n8n-io/n8n/actions/runs/7503946939/job/20429848500
Nevermind. Had to build the dist folder before tagging.

@netroy netroy deleted the fix-allow-langchain-nodes branch January 12, 2024 15:24
@ivov
Copy link

ivov commented Jan 12, 2024

@netroy Can you please update this release doc if it's outdated?

https://github.com/n8n-io/validate-n8n-pull-request-title#release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivov ivov ivov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegIvaniv @netroy @ivov