Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Settings #308

Open
hellopablo opened this issue Mar 29, 2021 · 0 comments
Open

Refresh Settings #308

hellopablo opened this issue Mar 29, 2021 · 0 comments
Assignees

Comments

@hellopablo
Copy link
Member

A scenario I come across often is changing a setting and some other part of the system not realising a value has changed.

Example:


module-invoice's settings class loads the payment driver service in order to detect which rivers are available. This internally does a check to see which is enabled, calling appSettings. This would happen as part of database migrations.

Later on, in the app migrations, we set a different driver. When running tests and we attempt to make a charge, the original value is used, and the new value is deemed invalid.


What would be nice is if setting objects could be refreshed, triggering a cascade of value updates meaning that wherever a value is used the next time it is checked, the updated value is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant