From 6f806c380c3b745c05e09cd0b23e229785339957 Mon Sep 17 00:00:00 2001 From: Morten Lied Johansen Date: Mon, 8 Apr 2024 10:42:24 +0200 Subject: [PATCH] Better name for const MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Vegar Sechmann Molvig Co-authored-by: Sindre Rødseth Hansen --- internal/reconcilers/google/gcp/cnrm.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/reconcilers/google/gcp/cnrm.go b/internal/reconcilers/google/gcp/cnrm.go index 5033a78..c38eb5f 100644 --- a/internal/reconcilers/google/gcp/cnrm.go +++ b/internal/reconcilers/google/gcp/cnrm.go @@ -10,11 +10,11 @@ import ( "google.golang.org/api/iam/v1" ) -const CNRMRoleName = "CustomCNRMRole" +const CNRMRoleId = "CustomCNRMRole" func (r *googleGcpReconciler) createCNRMRole(ctx context.Context, client *apiclient.APIClient, teamSlug string, projectId string) (*iam.Role, error) { parent := fmt.Sprintf("projects/%s", projectId) - name := fmt.Sprintf("projects/%s/roles/%s", projectId, CNRMRoleName) + name := fmt.Sprintf("projects/%s/roles/%s", projectId, CNRMRoleId) existingRole, _ := r.gcpServices.ProjectsRolesService.Get(name).Context(ctx).Do() // Create a new role @@ -65,7 +65,7 @@ func (r *googleGcpReconciler) createCNRMRole(ctx context.Context, client *apicli if existingRole == nil { req := &iam.CreateRoleRequest{ Role: role, - RoleId: CNRMRoleName, + RoleId: CNRMRoleId, } createdRole, err := r.gcpServices.ProjectsRolesService.Create(parent, req).Context(ctx).Do() reconcilers.AuditLogForTeam(