Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user that search-sha1 option is dangerous #55

Open
JeremyRand opened this issue Dec 13, 2020 · 1 comment
Open

Warn user that search-sha1 option is dangerous #55

JeremyRand opened this issue Dec 13, 2020 · 1 comment
Labels
enhancement New feature or request Hacktoberfest

Comments

@JeremyRand
Copy link
Member

We should warn the user that the search-sha1 command-line option is dangerous, due to SHA1 collision risk. In particular, if the user is issuing a command that increases the privileges of a certificate, and the creator of the certificate is malicious, the user might be inadvertently increasing the privileges of a completely different certificate too. The user should only use this option if one of the following is true:

  • The requested operation does not increase the privileges of the specified certificate.
  • The user fully trusts the creator of the specified certificate with whatever increased privileges are being requested.
@JeremyRand
Copy link
Member Author

(Side note: funnily enough, using the Name Constraints property is probably more secure than relying on the certificate's Name Constraints extension, because the extension is likely to be more vulnerable to CryptoAPI's SHA1 usage than the property is. Too bad Microsoft doesn't document the property. shrug)

@JeremyRand JeremyRand added enhancement New feature or request Hacktoberfest labels Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant