Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename states to jurisdictions #55

Merged
merged 2 commits into from
Sep 11, 2024
Merged

chore: Rename states to jurisdictions #55

merged 2 commits into from
Sep 11, 2024

Conversation

evadecker
Copy link
Member

What changed?

Rename US_STATES, usStates, state, etc. to JURISDICTIONS, jurisdictions, and jurisdiction.

Why?

"State" is unclear in an application that uses the word "state" for lots of other things. OpenLaws API uses "jurisdictions"—let's adopt that, too.

How was this change made?

Find/replace.

How was this tested?

Pre-commit type-checking.

Copy link

changeset-bot bot commented Sep 11, 2024

⚠️ No Changeset found

Latest commit: fbe1123

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@evadecker evadecker marked this pull request as ready for review September 11, 2024 01:41
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 4.21%
🟰 ±0%
117 / 2775
🔵 Statements 4.21%
🟰 ±0%
117 / 2775
🔵 Functions 1.36%
🟰 ±0%
1 / 73
🔵 Branches 4.41%
🟰 ±0%
3 / 68
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
convex/constants.ts 100% 100% 100% 100%
convex/forms.ts 0% 0% 0% 0% 1-4, 6-7, 9-14, 16-21, 23-31, 33-40, 42-48, 50-52, 54-61, 63-79, 81-88, 90-97, 99-103, 105, 107-110
convex/quests.ts 45.97% 100% 12.5% 45.97% 19-23, 29-30, 36-43, 49-50, 52, 54-63, 69-72, 78-81, 87-88, 90-95, 97-99
convex/schema.ts 100% 100% 100% 100%
src/routes/index.tsx 0% 0% 0% 0% 1-3, 10, 12-14, 16-18, 20, 22, 24-27, 29-33, 37, 40, 42-46, 48-49, 53
src/routes/admin/forms/$formId.tsx 0% 0% 0% 0% 1-3, 5, 7-9, 11-21, 23-24, 26-31, 33-34, 36-40, 45
src/routes/admin/forms/index.tsx 0% 0% 0% 0% 1-5, 7, 26-27, 29-31, 33-36, 41-49, 51-56, 58-59, 61-62, 64-65, 67-73, 75, 77-79, 81-92, 94, 96, 98-104, 106-111, 113-119, 121-123, 128-129, 132, 139, 141-145, 147-151, 153-157, 161-162, 164-168, 170-172, 176, 181-183, 187-189, 194, 203, 205-207, 209-212, 216-221, 223-225, 229-232, 236
src/routes/admin/quests/$questId.tsx 0% 0% 0% 0% 1-5, 15, 17-19, 21-29, 31-33, 35-38, 40-45, 47-51, 53-62, 70, 73-74, 78-85, 87-89, 92, 102
src/routes/admin/quests/index.tsx 0% 0% 0% 0% 1-5, 7, 26, 28-30, 32-35, 40-43, 45-48, 50-52, 54-56, 58-67, 69-74, 76-78, 82-83, 86, 93, 95-103, 105-109, 111-115, 119-121, 123, 126-131, 133-138, 141-143, 145, 150, 159, 161-163, 165-168, 172-178, 180-182, 186-189, 193
src/routes/quests/index.tsx 0% 0% 0% 0% 1-3, 10, 12-14, 16-17, 19-20, 22-28, 30-33, 39
Generated in workflow #32

@evadecker evadecker merged commit fb8d8da into main Sep 11, 2024
6 checks passed
@evadecker evadecker deleted the jurisdictions branch September 11, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant