Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BR-2] SSH session to auto-extend the breakpoint timer #7

Open
gmichelo opened this issue May 26, 2023 · 3 comments
Open

[BR-2] SSH session to auto-extend the breakpoint timer #7

gmichelo opened this issue May 26, 2023 · 3 comments
Assignees
Labels
help wanted Extra attention is needed linear

Comments

@gmichelo
Copy link
Contributor

gmichelo commented May 26, 2023

At the moment, the Breakpoint timer can expire even if there is an active SSH connection.

In the same way we run keepalives to keep the connection open, we can periodically extend the timer when at least an SSH session is active.

Here is where we spawn a goroutine to send the keepalives.
https://github.com/namespacelabs/breakpoint/blob/main/pkg/sshd/sshd.go#L81-L82

Similarly, we can have another goroutine periodically extending the waiter timer

BR-2

@gmichelo gmichelo added the help wanted Extra attention is needed label May 26, 2023
@hugosantos hugosantos changed the title SSH session to auto-extend the breakpoint timer [BR-2] SSH session to auto-extend the breakpoint timer May 26, 2023
@AvineshTripathi
Copy link

Hey I would like to look into this issue. Thank you!

@gmichelo gmichelo assigned gmichelo and AvineshTripathi and unassigned gmichelo Jun 15, 2023
@gmichelo
Copy link
Contributor Author

Hey @AvineshTripathi! Thanks for your interest! I assigned this issue to you. Let us know if you need any help!

@AvineshTripathi
Copy link

Hey @gmichelo being in the waiter func how do I know if the ssh session is still on . I know keepAlive is what keeps the ssh session up for a user now in order to communicate if ssh session is started or ended to the waiter func do I need to send a siglnal via chan based on ctx.Done present in the keepAlive and take actions on it in waiter.

Also when you said goroutine for waiter on what basis do we want that goroutine to return.

P.S. I am facing confusion regarding how components talk/connected to each other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed linear
Projects
None yet
Development

No branches or pull requests

3 participants