Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve API usability #18

Merged
merged 5 commits into from
May 7, 2024
Merged

Improve API usability #18

merged 5 commits into from
May 7, 2024

Conversation

nanashi-1
Copy link
Owner

This pull request changes the following:

  • Removal of annoying generics.
  • Combine NormalEpisodeMetadata and SpecialEpisodeMetadata into just EpisodeMetadata. Differences with their episode name are now changed into an enum called EpisodeId.
  • Use thiserror for error handling.
  • Use map_err instead of if let Err(e) when printing out the error.

@nanashi-1 nanashi-1 merged commit 8a0227b into master May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nanashi-1