Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacktoberfest #3

Open
sdomino opened this issue Oct 3, 2017 · 6 comments
Open

Hacktoberfest #3

sdomino opened this issue Oct 3, 2017 · 6 comments

Comments

@sdomino
Copy link
Contributor

sdomino commented Oct 3, 2017

If you're looking to get involved with Hacktoberfest, you've come to the right place. Just check out the guidelines and get started!

@shikya
Copy link

shikya commented Oct 3, 2017

Can I upgrade this to Angular 4?

@sdomino
Copy link
Contributor Author

sdomino commented Oct 3, 2017

@shikya we'd love to get up to date to the most recent version. It would be great too, to know how many people still use the older versions.

I wonder if we create separate repo's for nanobox-angular, nanobox-angular-2, and nanobox-angular-4 (or something)... or perhaps they are just branches.

Let me talk it out a bit with @sanderson and we'll come up with something. Then we'll create issues and reach back out to you. Thanks!

@sdomino
Copy link
Contributor Author

sdomino commented Oct 3, 2017

@shikya, sounds like, for these quickstarts, we're just going to try and maintain the newest version. So go ahead and updated it to Angular 4. Thanks! 👍

@samuelalvin
Copy link

@sdomino in the app folder, I see the .js and .js.map files. I don't think those files are necessary to be uploaded to the repository since we have the .ts files. May I create a pull request for deleting those .js and .js.map in the app folder and add them in the .gitignore?
I believe it will make the repo cleaner..

@jonyeezs
Copy link

I don't think you'd want for the quickstart app actually structure all that boilerplate files for you.

Rather, promote using angular-cli with nanobox to scaffold your app.

@sdomino
Copy link
Contributor Author

sdomino commented Oct 10, 2017

@jonyeezs I'm not super familiar with angular-cli myself, but I think what your suggesting is probably the correct route.

A quickstart should be the result of creating a new project, that runs with Nanobox, following whatever "best practices" or using whatever tools exist for any given language/framework.

Ideally, the application would be configured to run locally with Nanobox, but also function as a good "starter" app for deploying to production with Nanobox as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants