Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a better algorithm to solve Kepler equation #1427

Open
abhisrkckl opened this issue Oct 24, 2022 · 5 comments
Open

Use a better algorithm to solve Kepler equation #1427

abhisrkckl opened this issue Oct 24, 2022 · 5 comments
Assignees
Labels
enhancement student Good student project

Comments

@abhisrkckl
Copy link
Contributor

abhisrkckl commented Oct 24, 2022

Right now the Kepler equation is solved using the Newton-Raphson method.

def compute_eccentric_anomaly(self, eccentricity, mean_anomaly):

There are faster (and no less accurate) methods for doing this.
For example, Markley (1995) http://adsabs.harvard.edu/abs/1995CeMDA..63..101M

We should implement such a method instead of the Newton-Raphson method.

@dlakaplan
Copy link
Contributor

This seems like a good student project

@dlakaplan dlakaplan added the student Good student project label Oct 24, 2022
@AkashA98
Copy link
Contributor

I am quite interested in this stuff... If this is not time-sensitive, I can take this up...

@scottransom
Copy link
Member

I think this is a fine project, but we should temper our expectations! I suspect that the current solver isn't even close to the bottleneck in any of our calculations. N-R usually converges in only a couple iterations except in high eccentricity cases, I believe.

@dlakaplan
Copy link
Contributor

Yes, a more thorough analysis of where time is spent (which a few people have started but not finished) could be helpful to really focus us.

@abhisrkckl
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement student Good student project
Projects
None yet
Development

No branches or pull requests

4 participants