Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify API with mappy? #8

Open
kyleabeauchamp opened this issue Apr 2, 2018 · 5 comments
Open

Unify API with mappy? #8

kyleabeauchamp opened this issue Apr 2, 2018 · 5 comments

Comments

@kyleabeauchamp
Copy link

This is a nice project, but it would be really cool if mappy/minimap2 and bwapy happened to share the same python api.

@kyleabeauchamp
Copy link
Author

I wonder if @lh3 would be interested if the build system, packaging, and API were consistent with mappy.

@cjw85
Copy link
Member

cjw85 commented Apr 2, 2018

This package uses CFFI for creating the python extension whilst mappy uses cython. Creating and including libbwa.a here was simply the easiest thing to do (rather than listing all the source files in the python extension build). I think switching making the builds equivalent would amount to a rewrite.

The API here was chosen simply to mirror that of bwa mem with minimal fuss, albeit creating python objects. I think @lh3 has done pretty much the same in his mappy.

We had a short-lived minimappy project before @lh3 released his python binding. My understanding is @lh3 considers minimap2 to make bwa mem obsolete.

@lh3
Copy link

lh3 commented Apr 2, 2018

My understanding is @lh3 considers minimap2 to make bwa mem obsolete.

For long reads, minimap2 should be mostly better than bwa-mem. I wouldn't recommend to use bwa for long reads these days. I thought to replace bwa-mem for short reads, too, but it turns out that bwa-mem is still better at relatively noisy Illumina reads, so bwa-mem will stay for short reads.

@kyleabeauchamp
Copy link
Author

kyleabeauchamp commented Apr 2, 2018 via email

@cjw85
Copy link
Member

cjw85 commented Apr 2, 2018

@lh3 Thanks for your clarifying blogpost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants