From e9cabdcfdda40fca3a9ff41aa5b704f388feba1a Mon Sep 17 00:00:00 2001 From: Chris Seymour Date: Sat, 14 Oct 2023 17:56:51 +0100 Subject: [PATCH 1/4] larger windows runner --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2781dd976..c4c65910b 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -7,7 +7,7 @@ jobs: build: strategy: matrix: - os: [ubuntu-20.04, windows-2019] + os: [ubuntu-20.04, windows-2019-large] include: - os: windows-2019 arch: "-A x64" @@ -49,4 +49,4 @@ jobs: - name: Test dorado run: | cmake --build cmake-build --config Release --target install -j 4 - ctest -C Release --test-dir cmake-build --output-on-failure + ctest -C Release --test-dir cmake-build --output-on-failure --verbose From 4cce61626adad306e4bd9ee8143227e2f5241816 Mon Sep 17 00:00:00 2001 From: Chris Seymour Date: Sat, 14 Oct 2023 18:11:46 +0100 Subject: [PATCH 2/4] window-2019-large --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c4c65910b..1e9acf8bf 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -9,7 +9,7 @@ jobs: matrix: os: [ubuntu-20.04, windows-2019-large] include: - - os: windows-2019 + - os: windows-2019-large arch: "-A x64" runs-on: ${{ matrix.os }} steps: @@ -34,7 +34,7 @@ jobs: run: sudo apt-get update && sudo apt-get install -y --no-install-recommends libhdf5-dev libssl-dev libzstd-dev autoconf - name: Set up Windows path uses: myci-actions/export-env-var-powershell@1 - if: matrix.os == 'windows-2019' + if: matrix.os == 'windows-2019-large' with: name: PATH value: D:\a\dorado\dorado\dist\bin;$env:PATH From c65a71bd9d0ec41b722ffc16174ff8df5c1cdb66 Mon Sep 17 00:00:00 2001 From: Chris Seymour Date: Sat, 14 Oct 2023 18:36:41 +0100 Subject: [PATCH 3/4] remove cuda cache cleanup step --- .github/workflows/build.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1e9acf8bf..4c96ce865 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -25,10 +25,6 @@ jobs: id: cuda-toolkit with: cuda: '11.8.0' - - name: Cleanup CUDA cache - uses: JesseTG/rm@v1.0.3 - with: - path: D:\a\dorado\dorado\cuda_installer-windows-10.0.17763-11.8.0 - name: Install dependencies from apt if: matrix.os == 'ubuntu-20.04' run: sudo apt-get update && sudo apt-get install -y --no-install-recommends libhdf5-dev libssl-dev libzstd-dev autoconf From 9804bde9c2927cf9f5249d7028846c4d9d6be441 Mon Sep 17 00:00:00 2001 From: Chris Seymour Date: Sat, 14 Oct 2023 18:52:51 +0100 Subject: [PATCH 4/4] C: drive and 8 threads --- .github/workflows/build.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4c96ce865..48196c33a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -33,16 +33,16 @@ jobs: if: matrix.os == 'windows-2019-large' with: name: PATH - value: D:\a\dorado\dorado\dist\bin;$env:PATH + value: C:\a\dorado\dorado\dist\bin;$env:PATH - name: Build dorado run: | cmake -S . -B cmake-build ${{ matrix.arch }} - cmake --build cmake-build --config Release -j 4 + cmake --build cmake-build --config Release -j 8 - name: Cleanup torch uses: JesseTG/rm@v1.0.3 with: - path: D:\a\dorado\dorado\3rdparty + path: C:\a\dorado\dorado\3rdparty - name: Test dorado run: | - cmake --build cmake-build --config Release --target install -j 4 + cmake --build cmake-build --config Release --target install -j 8 ctest -C Release --test-dir cmake-build --output-on-failure --verbose