Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make setup/turnoff of tap devices optional #1319

Open
wjhun opened this issue Apr 8, 2022 · 0 comments
Open

make setup/turnoff of tap devices optional #1319

wjhun opened this issue Apr 8, 2022 · 0 comments

Comments

@wjhun
Copy link
Contributor

wjhun commented Apr 8, 2022

In ops/cmd/run_local_instance.go, network.SetupNetworkInterfaces() and network.TurnOffNetworkInterfaces() are called unconditionally if a tap device is specified. This is convenient behavior when the user does not already have bridge and tap devices configured, but an inconvenience if the user has such devices configured and wishes them to be persistent across invocations of ops. Adding a flag to disable all network device configuration (or disable it by default) would help in these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants