Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain.shape method should be a property #411

Open
4 tasks done
korvinos opened this issue May 15, 2019 · 0 comments · May be fixed by #500
Open
4 tasks done

Domain.shape method should be a property #411

korvinos opened this issue May 15, 2019 · 0 comments · May be fixed by #500
Labels
good first issue

Comments

@korvinos
Copy link
Member

korvinos commented May 15, 2019 •
edited by opsdep
Loading

Idea

The Domain class has a shape method which returns the (y, x) tuple. The method is inherited by the Nansat object and widely used. The idea is to make a shape property instead of the method. It will be more consistent with the numpy then.

TODO

  • Create a shape property in the Domain class by analogy with the existing shape method

  • Create a deprication warning in the shape method

  • Fix the mappers and all other code using the shape method

  • Fix the tests
opsdep pushed a commit that referenced this issue Mar 10, 2021
#411 property decorator with its setter
b584f4a
opsdep pushed a commit that referenced this issue Mar 10, 2021
#411 remove para. in tests
e7c9757
opsdep pushed a commit that referenced this issue Mar 10, 2021
#411 remove para. in nansat.py
55ceaff
opsdep pushed a commit that referenced this issue Mar 10, 2021
#411 remove para. in opendap.py
bb3d8d8
opsdep pushed a commit that referenced this issue Mar 10, 2021
#411 remove para. in domain.py
a370093
opsdep pushed a commit that referenced this issue Mar 10, 2021
#411 minors
7697ea8
@aperrin66 aperrin66 linked a pull request Dec 27, 2021 that will close this issue
#411 property decorator with its setter #500
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#411 property decorator with its setter nansencenter/nansat
1 participant
@korvinos