Skip to content
This repository has been archived by the owner on Sep 17, 2019. It is now read-only.

Get rid of "print" in base.py #145

Open
Mierdin opened this issue Nov 22, 2016 · 1 comment
Open

Get rid of "print" in base.py #145

Mierdin opened this issue Nov 22, 2016 · 1 comment
Labels
Milestone

Comments

@Mierdin
Copy link

Mierdin commented Nov 22, 2016

I am working on a StackStorm pack for NAPALM (more on that later! 😄) and my sensor is designed to check on a few devices periodically for changes. In this case, a connection failure is perfectly normal, and I'd like to keep the stackstorm logs clean of such an event. However, this shows that the "catch-all" exception method is being printed, instead of leveraging a more traditional logging facility. When I'm looking at the console for my sensor, this makes things look dirty.

I can make the change, but wanted to open an issue in case this was done for a reason. The logging module is used elsewhere, could this be done here too instead of printing?

@dbarrosop
Copy link
Member

I am working on a StackStorm pack for NAPALM (more on that later! 😄)

Wut! How cool is that!? : )

The issue at hand

The print there is to encourage users finding exceptions that we are not normalizing to open an issue. If you prefer to use the logging subsystem or just change the print so it goes to stderr instead I am fine with that : ) I just didn't want to manipulate the original Exception.

@mirceaulinic mirceaulinic added this to the APPROVED milestone Nov 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants