Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constant coding style #8

Open
omgcheese opened this issue Apr 26, 2018 · 1 comment
Open

constant coding style #8

omgcheese opened this issue Apr 26, 2018 · 1 comment
Assignees
Labels
cleancode newbie Low hanging fruits.
Milestone

Comments

@omgcheese
Copy link

There are default values are set for instance variables:

    private static final int defaultNumberOfWaves = 3;
    private static final float defaultFrequency = 2.0f;
    private static final float defaultAmplitude = 0.15f;
    private static final float defaultPhaseShift = -0.05f;
    private static final float defaultDensity = 5.0f;
    private static final float defaultPrimaryLineWidth = 3.0f;
    private static final float defaultSecondaryLineWidth = 1.0f;
    private static final int defaultBackgroundColor = Color.BLACK;
    private static final int defaultWaveColor = Color.WHITE;
    private static final float defaultXAxisPositionMultiplier = 0.5f;

These constants are not following google java style guide:
https://google.github.io/styleguide/javaguide.html#s5.2.4-constant-names

I recommend we start following the guideline as we make progress with this repo.

@narayanacharya6
Copy link
Owner

Good point. I'll pick this up and get it in this weekend.

@narayanacharya6 narayanacharya6 self-assigned this Apr 28, 2018
@narayanacharya6 narayanacharya6 added this to the 0.9.4 milestone Apr 28, 2018
@narayanacharya6 narayanacharya6 added the newbie Low hanging fruits. label Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleancode newbie Low hanging fruits.
Projects
None yet
Development

No branches or pull requests

2 participants