Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't find unit tests for PivotsHL #85

Closed
femtotrader opened this issue Dec 23, 2023 · 2 comments
Closed

Can't find unit tests for PivotsHL #85

femtotrader opened this issue Dec 23, 2023 · 2 comments

Comments

@femtotrader
Copy link
Contributor

femtotrader commented Dec 23, 2023 •
edited
Loading

Hi,

I think tests for PivotsHL are missing.
What is your reference implementation for testing?

Kind regards

https://github.com/nardew/talipp/blob/master/talipp/indicators/PivotsHL.py
https://github.com/search?q=repo%3Anardew%2Ftalipp%20PivotsHL&type=code
@femtotrader femtotrader mentioned this issue Dec 23, 2023
Open
@nardew
Copy link
Owner

nardew commented Dec 23, 2023

Same as for #87.

femtotrader added a commit to femtotrader/talipp that referenced this issue Jan 2, 2024
@femtotrader
Create test_PivotsHL.py
ddea814 
Closes nardew#85
@femtotrader femtotrader mentioned this issue Jan 2, 2024
Closed
@nardew
Copy link
Owner

nardew commented May 25, 2024

PivotsHL indicator has been deprecated in favour of ZigZag indicator. ZigZag indicator can be configured to act as PivotsHL, see ZigZag documentation for more details.

@nardew nardew closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create test_PivotsHL.py femtotrader/talipp
2 participants
@femtotrader @nardew