Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcn.notices.icecube.lvk_nu_track_search example JSON package has bad/missing keys #1230

Closed
swyatt7 opened this issue Aug 14, 2023 · 3 comments
Assignees

Comments

@swyatt7
Copy link
Contributor

swyatt7 commented Aug 14, 2023

I've set up a gcn-kafka listener to pickup detected coincident icecube neutrino events to LVK alerts for the Gravitational Wave Treasure Map. I used the example json package and have noticed inconsistencies in the actual alerts being sent over this kafka stream that caused some inability to associate events to LVK alerts.

  • The ref_ID keyword in the example is actually ref_id in the alerts, which caused us to actually never associate the alerts to the events.

  • The format of the ref_id was never documented. We just assumed it would be the graceid for the event like it is in the example, but the actual alert ref_id is in the form of graceid_iter_alerttype like S230814r-2-Preliminary.

  • There is no reference keyword in the package that links to the gcn.notices.LVK.alert id.

  • The link to the package $schema returns 404

  • In the coincident_events list, the spatial keywords are behind a "localization" dictionary, that isn't in the example.

We will update our listener to adapt to what is being sent over the kafka stream, yet request the example.json package also be updated to reflect what is being sent out over kafka.

Best,

-SW

@blaufuss
Copy link
Contributor

@swyatt7 thanks for the deep checking and apologies for the slow reply.

nasa-gcn/gcn-schema#106

Corrects the example. Additionally, there are a few tweaks we need to make the example match the schema. These are not yet in production, but staged and ready to go. Once we get the PR accepted in gcn-schema and new example published, we will change our production alert sender and close/update this issue when live.

Just to be clear: example in PR matches what WILL be coming after new version is live.

Thanks again, welcome any additional feedback

@blaufuss
Copy link
Contributor

@swyatt7 this has been merged and tagged as a new stable version of the gcn-schema.

Our sender is being updated now and should be online in the next ~10 minutes to produce gcn notices that match the schema and example published there:

https://raw.githubusercontent.com/nasa-gcn/gcn-schema/v2.0.0/gcn/notices/icecube/LvkNuTrackSearch.example.json
https://raw.githubusercontent.com/nasa-gcn/gcn-schema/v2.0.0/gcn/notices/icecube/LvkNuTrackSearch.schema.json

Please get in touch or send us an issue if you find any problems.

Best
Erik

@blaufuss
Copy link
Contributor

@lpsinger I do not have permissions to close this ticket assigned to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants