-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMR-10132: Fix stac-browser Stac item Search unmapped CMR keys #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
==========================================
+ Coverage 88.05% 88.22% +0.16%
==========================================
Files 24 24
Lines 1164 1180 +16
Branches 256 261 +5
==========================================
+ Hits 1025 1041 +16
Misses 139 139 ☔ View full report in Codecov by Sentry. |
eudoroolivares2016
requested review from
macrouch,
dpesall,
daniel-zamora,
dmistry1 and
william-valencia
November 4, 2024 22:03
jaybarra
reviewed
Nov 5, 2024
jaybarra
approved these changes
Nov 5, 2024
dpesall
approved these changes
Nov 5, 2024
dmistry1
approved these changes
Nov 6, 2024
eudoroolivares2016
force-pushed
the
CMR-10232
branch
from
November 6, 2024 17:23
6b402a4
to
1ebacf2
Compare
…ld and normalizing datetime param to cmr startDate field
CMR-10232: remove logs
eudoroolivares2016
force-pushed
the
CMR-10232
branch
from
November 6, 2024 21:25
1ebacf2
to
960fc73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Update sorting maps to include a
datetime
mapping to CMR'sstartDate
field. Refactor sortKeys to map to CMR fields depending if the search is foritems
or forcollections
so that we can sort byid
field accordinglyWhat is the Solution?
Adding search context to the query param and a util to direct the request to the correct CMR key field. Also adding a mapping for the
datetime
fieldWhat areas of the application does this impact?
Testing
Reproduction steps
Id
for the collection search sorting worksId
for the items search sorting worksAttachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
Checklist