Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature]: Change definition of "m" in DISP-S1 processing context #987

Open
philipjyoon opened this issue Sep 12, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request needs triage Issue that requires triage pcm.r03-disp-s1

Comments

@philipjyoon
Copy link
Contributor

Checked for duplicates

Yes - I've already checked

Alternatives considered

Yes - and alternatives don't suffice

Related problems

No response

Describe the feature request

Currently m=1 means that no compressed CSLC is passed into the DISP-S1 PGE. m=2 means that one set of compressed CSLCs are passed into the DISP-S1 PGE, and so on. It was defined this way due to past miscommunication with ADT.

We want to change so that m=0 means no compressed cslcs passed in; m=1 means one set of compressed cslcs pass in; and so on.

While this is a trivial change, it will have wide source code impacts including historical processing executable. Make sure to unit and regression test everything (also update those tests accordingly)

@philipjyoon philipjyoon added enhancement New feature or request needs triage Issue that requires triage labels Sep 12, 2024
@philipjyoon philipjyoon self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Issue that requires triage pcm.r03-disp-s1
Projects
None yet
Development

No branches or pull requests

2 participants