Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: RTC-S1-STATIC fails integration test #577

Open
RKuttruff opened this issue Jan 31, 2025 · 1 comment
Open

[Bug]: RTC-S1-STATIC fails integration test #577

RKuttruff opened this issue Jan 31, 2025 · 1 comment
Labels
bug Something isn't working needs triage Bug report that requires triage

Comments

@RKuttruff
Copy link
Contributor

Checked for duplicates

Yes - I've already checked

Describe the bug

When checking the PGE's integration tests while checking that #575 didn't break anything, I noticed RTC-S1-STATIC failed during text render. Inspection of the old ISO XML template showed 4 attributes that are expected to be absent in the static product.

  • identification/staticLayersDataAccess
  • processingInformation/parameters/noiseCorrectionApplied
  • processingInformation/parameters/radiometricTerrainCorrectionApplied
  • processingInformation/algorithms/noiseCorrectionAlgorithmReference

These need to be either marked as optional or a separate MPC should be provided for RTC-S1-STATIC with these removed. RTC-S1-STATIC contains no expected attributes that are absent in RTC-S1 (it is a strict subset of RTC-S1).

What did you expect?

I expected the RTC-S1 int test suite to either pass or fail in the PGE render jinja2 validation step I was testing in #575, but not before then.

Reproducible steps

1. Build RTC-S1 Docker image
2. Run RTC-S1 int test

Environment

opera-dev-pge
@RKuttruff RKuttruff added bug Something isn't working needs triage Bug report that requires triage labels Jan 31, 2025
@RKuttruff
Copy link
Contributor Author

Running Docker image opera_pge/rtc_s1:rileykk-dev with static layer workflow
Running preprocessor for RtcS1PreProcessorMixin
Starting SAS execution for RtcS1Executor
Running postprocessor for RtcS1PostProcessorMixin
Traceback (most recent call last):
  File "/home/rtc_user/opera/pge/rtc_s1/rtc_s1_pge.py", line 744, in augment_measured_parameters
    mp = mp[key_path.pop(0)]
KeyError: 'staticLayersDataAccess'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/rtc_user/opera/scripts/pge_main.py", line 191, in <module>
    pge_main()
  File "/home/rtc_user/opera/scripts/pge_main.py", line 187, in pge_main
    pge_start(run_config_filename)
  File "/home/rtc_user/opera/scripts/pge_main.py", line 161, in pge_start
    pge.run()
  File "/home/rtc_user/opera/pge/base/base_pge.py", line 874, in run
    self.run_postprocessor(**kwargs)
  File "/home/rtc_user/opera/pge/rtc_s1/rtc_s1_pge.py", line 997, in run_postprocessor
    self._stage_output_files()
  File "/home/rtc_user/opera/pge/rtc_s1/rtc_s1_pge.py", line 917, in _stage_output_files
    self._assign_filename(output_product, self.runconfig.output_product_path)
  File "/home/rtc_user/opera/pge/base/base_pge.py", line 548, in _assign_filename
    final_filename = rename_function(input_filepath)
  File "/home/rtc_user/opera/pge/rtc_s1/rtc_s1_pge.py", line 569, in _static_metadata_filename
    rtc_filename = self._rtc_filename(inter_filename, static_layer_product=True)
  File "/home/rtc_user/opera/pge/rtc_s1/rtc_s1_pge.py", line 274, in _rtc_filename
    product_metadata = self._collect_rtc_product_metadata(
  File "/home/rtc_user/opera/pge/rtc_s1/rtc_s1_pge.py", line 820, in _collect_rtc_product_metadata
    output_product_metadata['MeasuredParameters'] = self.augment_measured_parameters(output_product_metadata)
  File "/home/rtc_user/opera/pge/rtc_s1/rtc_s1_pge.py", line 752, in augment_measured_parameters
    self.logger.critical(self.name, ErrorCode.ISO_METADATA_DESCRIPTIONS_CONFIG_INVALID, msg)
  File "/home/rtc_user/opera/util/logger.py", line 410, in critical
    raise RuntimeError(description)
RuntimeError: Measured parameters configuration contains a path identification/staticLayersDataAccess that is missing from the output product
ERROR conda.cli.main_run:execute(124): `conda run sh -c exec ${CONDA_ROOT}/bin/pge_docker_entrypoint.sh  "${@}" -- --file /home/rtc_user/runconfig/opera_pge_rtc_s1_static_delivery_5.2_final_runconfig.yaml` failed. (See above for error)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Bug report that requires triage
Projects
None yet
Development

No branches or pull requests

1 participant