Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISP-S1 Final SAS v0.5.4 Acceptance Test #593

Closed
11 tasks done
collinss-jpl opened this issue Feb 28, 2025 · 1 comment
Closed
11 tasks done

DISP-S1 Final SAS v0.5.4 Acceptance Test #593

collinss-jpl opened this issue Feb 28, 2025 · 1 comment
Assignees
Labels
must have Feature is a must have pge.r.03 PGE Release 03 pge.sprint.r06.06 Sprint 06 for PGE Release 06

Comments

@collinss-jpl
Copy link
Collaborator

collinss-jpl commented Feb 28, 2025

Acceptance Test Procedure Steps

  • Download the delivered SAS Docker image tarball from Artifactory
    • general/gov/nasa/jpl/opera/adt/disp_s1/r6.4/final/dockerimg_disp_s1_final.tar
  • Download the delivered "golden" test data assets included with SAS delivery from Artifactory
    • general/gov/nasa/jpl/opera/adt/disp_s1/r6.4/final/delivery_data_small.tar
  • Optional: Download the delivered documentation for reference
    • general/gov/nasa/jpl/opera/adt/disp_s1/r6.4/final/documents/
  • If required by the SAS, ensure the instance type of the development machine is set to the correct chip family (Intel vs AMD)
  • Load SAS docker image and deploy test data assets on development machine
  • Modify provided RunConfig(s) as necessary (see previous AT wiki instructions, if available)
  • Execute SAS container using provided sample inputs and RunConfig
  • Perform Quality Assurance comparison check of output products with expected products from "golden" test data
  • Create/Update Acceptance Testing Procedure wiki page
    • Be sure to include any changes to test data structure, file permissions, RunConfig changes etc.
  • Include the results of Quality Assurance check at the bottom of the wiki page
    • Include any details on known failures or workarounds, and include a sample of the expected output from the comparison script
    • If the results of the comparison step are contingent on a particular instance type or chip family, be sure to note that as well
  • Optional: Upload results of the Acceptance Test to S3
    • If the comparison step or the SAS itself is failing, this can be critical for sharing results with ADT
    • Otherwise, if everything is passing this step can be considered optional
@collinss-jpl collinss-jpl added must have Feature is a must have pge.r.03 PGE Release 03 pge.sprint.r06.06 Sprint 06 for PGE Release 06 labels Feb 28, 2025
@RKuttruff
Copy link
Contributor

Tests have passed on r6a.4xlarge

Results archived on S3 at acceptance_test/disp_s1/final_0.5.4/

I added a bold note at the top of the A/T procedure wiki page to show what chip family we need since there were two places in the page that mentioned it, one said Intel, the other said AMD. I unfortunately read the wrong one first. For completeness, the results of that run are archived at acceptance_test/disp_s1/final_0.5.4_intel/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must have Feature is a must have pge.r.03 PGE Release 03 pge.sprint.r06.06 Sprint 06 for PGE Release 06
Projects
None yet
Development

No branches or pull requests

2 participants