Crop Production Regression model could use improved validation of crop names

[emilyanndavis]

Both Crop Production models (Percentile and Regression) validate each crop name in the user-provided LULC to crop table by checking (in the model-provided data) for the existence of a climate bin raster for that crop. While this is appropriate for the Percentile model, the Regression model supports only a small subset of those crops.

If I run the Regression model with an LULC to crop table containing avocado—which is supported by the Percentile model but not by the Regression model—the run fails on a FileNotFoundError on an attempt to open avocado_regression_yield_table.csv, because that file does not exist.

This error could be avoided by improving the initial validation of crop names. Instead of checking for the associated climate bin raster, the Regression model should check for the relevant regression yield table, since that is truly the limiting factor for this model.