Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would an LRUCache add anything to convolve_2d? #373

Open
phargogh opened this issue Feb 28, 2024 · 0 comments · May be fixed by #411
Open

Would an LRUCache add anything to convolve_2d? #373

phargogh opened this issue Feb 28, 2024 · 0 comments · May be fixed by #411
Labels
question Further information is requested

Comments

@phargogh
Copy link
Member

Caching is an important way that we can avoid disk I/O, as we have been doing in routing for some time now. GDAL states that it already has an LRU caching mechanism (and has for a long time), and also python now has an LRUCache in the standard library.

So, do we gain anything performance-wise to implement a python block cache of numpy arrays?
@phargogh phargogh added the question Further information is requested label Feb 28, 2024
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Oct 11, 2024
@phargogh
Adding an LRUCache to convolve_2d.
882b868 
RE:natcap#373
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Oct 11, 2024
@phargogh
Noting change in HISTORY. RE:natcap#373
93993bb
@phargogh phargogh linked a pull request Oct 16, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an LRU Cache to the convolution worker phargogh/pygeoprocessing
1 participant
@phargogh