Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose niced_processes option through python API rather than package extra #84

Open
emlys opened this issue Apr 6, 2023 · 0 comments
Open
Labels
task Code changes that are not functional
Milestone

Comments

@emlys
Copy link
Member

emlys commented Apr 6, 2023

@phargogh said on slack:

I can’t honestly remember why we didn’t just require psutil. psutil has been available on windows from PyPI at least as long as taskgraph has, so I doubt it’s an installation issue.
But also, the right thing to do for taskgraph should be to allow the user to define whether they want processes to be nice’d instead of changing behavior based on the available imports. So instead, I’d suggest that we require psutil at install time and then maybe allow the user to define (probably at Graph creation) whether they want to assign a process priority. If not, the priority should be inherited from the spawning process.

@emlys emlys added the task Code changes that are not functional label Apr 6, 2023
@phargogh phargogh added this to the 1.0 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Code changes that are not functional
Projects
None yet
Development

No branches or pull requests

2 participants