-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accounts-ui-bootstrap and acccounts-ui-bs3-and-blaze dropdown stops working when x-editable added #20
Comments
Hello again! I found something: I'm using less-bootstrap-3, not bootstrap-3. When I comment out the api.use('bootstrap-3') line in package.js it works ok. I tried adding bootstrap-3 package to my project but it doesn't worked. To replace the content by api.use('less-bootstrap-3') doesn't work, so I leave the line commented out by now... |
well, this package does depend on bootstrap-3 - i suggest you fork the repo with that dependency commented out (like you mentioned) i dont think there is really a problem to be addressed here |
Yeah, the problem is, when bootstrap is added more than once, it starts to misbehave. I also would like to see this dependency removed, so I can use another bootstrap package. Isn't possible to check if bootstrap is already added before requiring it ? |
Hi, Perhaps you could change the package.js file to make the bootstrap package a weak dependency? That way, your project already has the mizzao:bootstrap-3 package, it will use that. If not (e..g if user is using the nemo64:bootstrap package), it will hopefully still work fine ? |
well, as i understand the weak dependency, that would mean that you have to manually include a bootstrap package. would that be troublesome for novice users? i'm just a little concerned about making assumptions that developers will always manually include their own flavor of bootstrap |
It looks like the bootstrap dependency was changed to a weak dependency a few weeks ago. Is this still an issue with that modification? |
Hello!
this is the only problem I found using this great package.
Accounts ui dropdown stopped working suddenly and after some testing removing packages one by one I found it was x-editable who was causing the problem.
I'm trying to find why but I'm pretty new to meteor and I can't find the reason by now.
The text was updated successfully, but these errors were encountered: