Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to register custom handlers #5

Open
Nopik opened this issue Feb 25, 2013 · 3 comments
Open

Unable to register custom handlers #5

Nopik opened this issue Feb 25, 2013 · 3 comments

Comments

@Nopik
Copy link

Nopik commented Feb 25, 2013

It would be nice to be able to register new keywords and their respective handlers.

@Nopik
Copy link
Author

Nopik commented Feb 25, 2013

Preferably the custom handlers should be asynchronous, too. For example: there is an API receiving JSON requests. Each request need to have 'access_token' property with valid session ID inside. Custom handler would check DB (async) for token validity and matched or failed.

@pvorb
Copy link
Contributor

pvorb commented Feb 25, 2013

👍 That would be helpful.

@natesilva
Copy link
Owner

This would require async validation. If the validation controller is made more async-aware, it could be done.

I had thought about this in the context of validating an e-mail address. You’d register a handler for a keyword and make some network calls to check if the address was valid.

Major change is that the validation controller, which is now recursive, needs to use callbacks everywhere if it’s invoked in async mode. Once that happens, adding new keywords is easy (famous last words, I know). I can hack on that in the dev branch next chance I get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants