Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for OrdinaryDiffEq split #322

Closed
ChrisRackauckas opened this issue Aug 19, 2024 · 3 comments
Closed

Updates for OrdinaryDiffEq split #322

ChrisRackauckas opened this issue Aug 19, 2024 · 3 comments

Comments

@ChrisRackauckas
Copy link
Contributor

A few changes will need to be made:

@nathanaelbosch
Copy link
Owner

#325 implements get_fsalfirstlast, but in the minimal way to just fix the current installation errors by overloading

OrdinaryDiffEq.get_fsalfirstlast(cache::EKCache, rate_prototype) = nothing, nothing

I also had OrdinaryDiffEq.isfsal(::AbstractEK) = false in my code for a while, so I'm a bit suprised to even run into this issue?

Other then that I will make sure to move over to OrdinaryDiffEqCore as soon as I find the time, and I will update this thread whenever I run into some issues. Thanks again for opening this!

@ChrisRackauckas
Copy link
Contributor Author

I also had OrdinaryDiffEq.isfsal(::AbstractEK) = false in my code for a while, so I'm a bit suprised to even run into this issue?

We should create a generic fallback for this case.

@nathanaelbosch
Copy link
Owner

Thanks a lot for the PR #326!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants