Invalid upload ID error is not explicit enough

[jonahkagan]

I was getting an error from Knox when creating an upload that said 'Invalid upload ID'. Looking at the code, this occurs when the response from AWS is missing the field UploadId:

knox-mpu/lib/multipartupload.js

Line 71 in d1e1456

if (!body.UploadId) return callback('Invalid upload ID');

.

The error message suggests that this is a user error (i.e. that the user passed in an invalid upload id), when really the error is that the response from AWS is missing an upload id.

I inserted some logging to figure out the cause of the problem, and in my case it was due to an invalid AWS Access Key Id. Here's the body of the response:

{ Code: 'InvalidAccessKeyId',
  Message: 'The AWS Access Key Id you provided does not exist in our records.',
  RequestId: <some string>,
  HostId: <some string>,
  AWSAccessKeyId: <my bad key>}

It would be nice to either see this body when the error occurs or at least have a more explicit error message that suggests the cause of the issue. I'm happy to submit a pull request with a fix if you have an idea of how you'd want to fix it.

[mikermcneil]

@jonahkagan I think that'd be a great addition, but Im just some dude

[rvaiya]

@mikermcneil it's the dude's that make the difference