Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit an incomplete event when maxRetries is exceeded #44

Open
yamsellem opened this issue Aug 25, 2015 · 0 comments
Open

Emit an incomplete event when maxRetries is exceeded #44

yamsellem opened this issue Aug 25, 2015 · 0 comments

Comments

@yamsellem
Copy link

If a part failed to be uploaded, a failed event is emitted.
Then a new upload is launched for this part until maxRetries is reached.

But, if every uploads of a part fail, the complete event is trigger anyway.
This event is misleading, because the full upload is done, but the file is incomplete.
For example, if there is only one part, the complete event will be triggered with a size of 0.

Replacing this event by done and triggering an incomplete event make more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant