Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch Discourse usernames from smart contract (#85) #89

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Fetch Discourse usernames from smart contract (#85) #89

merged 1 commit into from
Mar 24, 2023
+9,860 −1

Conversation

aahna-ashina
Copy link
Member

@aahna-ashina aahna-ashina commented Mar 22, 2023 •
edited
Loading

Dework Task

Related GitHub Issue

closes #85

How Has This Been Tested?

  • localhost: npm run generate-csv
  • Status checks pass
  • Works on Goerli
  • Works on Mainnet

Are There Admin Tasks?

@aahna-ashina aahna-ashina requested a review from a team as a code owner March 22, 2023 06:22
@aahna-ashina aahna-ashina self-assigned this Mar 22, 2023
@aahna-ashina aahna-ashina changed the title Fetch discourse usernames from smart contract (#85) Fetch Discourse usernames from smart contract (#85) Mar 22, 2023
johnmark13
johnmark13 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@johnmark13 johnmark13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going this route, there was a discussion somewhere about not doing this and using another mechanism for storing the data and I think someone created a single contract to hold all username data?

data-sources/discourse/src/generate-csv.ts Show resolved Hide resolved
@aahna-ashina aahna-ashina mentioned this pull request Mar 24, 2023
Open
@aahna-ashina
Copy link
Member Author

Are we going this route, there was a discussion somewhere about not doing this and using another mechanism for storing the data and I think someone created a single contract to hold all username data?

@johnmark13 If someone wants to refactor the current version of the software, feel free to open a pull request for it 😄

@aahna-ashina aahna-ashina merged commit aea89f2 into main Mar 24, 2023
@aahna-ashina aahna-ashina deleted the fetch-Discourse-usernames-from-smart-contract-#85 branch March 24, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmark13 johnmark13 johnmark13 approved these changes

@okhaimie-dev okhaimie-dev Awaiting requested review from okhaimie-dev

@pythonpete32 pythonpete32 Awaiting requested review from pythonpete32

Assignees

@aahna-ashina aahna-ashina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch Discourse usernames from smart contract
2 participants
@aahna-ashina @johnmark13